From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove dynamically allocated hashtables
Date: Tue, 21 Apr 2015 10:34:55 +0200 [thread overview]
Message-ID: <2761811.k3orNp26PZ@bentobox> (raw)
In-Reply-To: <1427037821-11565-1-git-send-email-sven@narfation.org>
On Sunday 22 March 2015 16:23:40 Sven Eckelmann wrote:
> @@ -628,12 +638,13 @@ struct batadv_priv_tvlv {
> * struct batadv_priv_dat - per mesh interface DAT private data
> * @addr: node DAT address
> * @hash: hashtable representing the local ARP cache
> + * @hash_lock: locks for each hashtable buckets
> * @work: work queue callback item for cache purging
> */
> #ifdef CONFIG_BATMAN_ADV_DAT
> struct batadv_priv_dat {
> batadv_dat_addr_t addr;
> - struct batadv_hashtable *hash;
> + struct batadv_hashbucket hash[1024];
> struct delayed_work work;
> };
> #endif
There is no hash_lock and thus this hash_lock comment should not be added.
Kind regards,
Sven
prev parent reply other threads:[~2015-04-21 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 15:23 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Remove dynamically allocated hashtables Sven Eckelmann
2015-03-22 15:23 ` [B.A.T.M.A.N.] [PATCHv5 2/2] batman-adv: Define the size of hashtables by hash bits Sven Eckelmann
2015-04-21 8:34 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2761811.k3orNp26PZ@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox