Re: [B.A.T.M.A.N.] [PATCH v2 1/5] batman-adv: make the GW selection class algorithm specific

Antonio Quartulli
2016-05-13T13:21:52Z

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Fri, May 13, 2016 at 06:44:02PM +0800, Marek Lindner wrote:
> On Tuesday, May 10, 2016 18:06:05 Antonio Quartulli wrote:
> > + return __batadv_store_uint_attr(buff, count, 0, BATADV_TQ_MAX_VALUE,
> > + batadv_post_gw_reselect, attr,
> > + &bat_priv->gw.sel_class,
> > + bat_priv->soft_iface);
> > +}
>
> Why are you changing the allowed minimum from '1' to '0' ?

previous change that I did not "undo". Will fix that.

>
>
> > /**
> > + * struct batadv_algo_gw_ops - mesh algorithm callbacks (GW specific)
> > + * @bat_store_sel_class: parse and stores a new GW selection class
> > + * @bat_show_sel_class: prints the current GW selection class
> > + */
> > +struct batadv_algo_gw_ops {
> > + ssize_t (*bat_store_sel_class)(struct batadv_priv *bat_priv, char
> > *buff, + size_t count);
> > + ssize_t (*bat_show_sel_class)(struct batadv_priv *bat_priv, char
> > *buff); +};
>
> No need to introduce the 'bat_' prefix if the next patch removes it.

I wanted to be consistent. I will invert the patches then.

Thanks !

Cheers,

--
Antonio Quartulli

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]