From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [RFC v2] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs
Date: Thu, 10 May 2018 17:50:48 +0200 [thread overview]
Message-ID: <2798092.n9DkCtfipy@sven-edge> (raw)
In-Reply-To: <20180510144137.32244-1-mareklindner@neomailbox.ch>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Donnerstag, 10. Mai 2018 16:41:37 CEST Marek Lindner wrote:
> rcu_read_lock();
> hlist_for_each_entry_rcu(vlan, &bat_priv->softif_vlan_list, list) {
> + vlan_entries = atomic_read(&vlan->tt.num_entries);
> + if (vlan_entries < 1)
> + continue;
> +
> num_vlan++;
> - num_entries += atomic_read(&vlan->tt.num_entries);
> + total_entries += vlan_entries;
> }
Please submit it on top of the maint branch before submitting it the next
time. The rcu_read_lock isn't there anymore.
The rest also applies only with some offsets (which sound like you have some
other modifications in your branch).
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-10 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:55 [B.A.T.M.A.N.] [RFC PATCH] batman-adv: mitigate issue when empty vlan is received Leonardo Mörlein
2018-05-07 6:32 ` Sven Eckelmann
2018-05-07 8:06 ` me
2018-05-07 10:23 ` Sven Eckelmann
2018-05-08 8:45 ` Sven Eckelmann
2018-05-09 14:08 ` Marek Lindner
2018-05-09 16:06 ` [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs Marek Lindner
2018-05-09 17:21 ` Sven Eckelmann
2018-05-09 18:20 ` Sven Eckelmann
2018-05-09 20:38 ` Sven Eckelmann
2018-05-09 21:34 ` lemoer
2018-05-10 9:12 ` Antonio Quartulli
2018-05-10 10:28 ` Marek Lindner
2018-05-10 14:41 ` [B.A.T.M.A.N.] [RFC v2] " Marek Lindner
2018-05-10 15:50 ` Sven Eckelmann [this message]
2018-05-11 15:58 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2798092.n9DkCtfipy@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox