From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix multicast TT issues with bogus ROAM flags
Date: Tue, 12 Jun 2018 21:47:41 +0200 [thread overview]
Message-ID: <2837973.EqbrSDaRnS@sven-edge> (raw)
In-Reply-To: <20180606224624.10141-2-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Donnerstag, 7. Juni 2018 00:46:24 CEST Linus Lüssing wrote:
> When a (broken) node wrongly sends multicast TT entries with a ROAM
> flag then this causes any receiving node to drop all entries for the
> same multicast MAC address announced by other nodes, leading to
> packet loss.
>
> Fix this DoS vector by only storing TT sync flags. For multicast TT
> non-sync'ing flag bits like ROAM are unused so far anyway.
>
> Fixes: 405cc1e5a81e ("batman-adv: Modified forwarding behaviour for multicast packets")
> Reported-by: Leonardo Mörlein <me@irrelefant.net>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Added as c7054ffae0c3 [1]
Thanks,
Sven
[1] https://git.open-mesh.org/batman-adv.git/commit/c7054ffae0c3b08bb4bef3cffee1e0a543e14096
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-06-12 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 22:46 [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Avoid storing non-TT-sync flags on singular entries too Linus Lüssing
2018-06-06 22:46 ` [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix multicast TT issues with bogus ROAM flags Linus Lüssing
2018-06-12 19:47 ` Sven Eckelmann [this message]
2018-06-12 19:46 ` [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Avoid storing non-TT-sync flags on singular entries too Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2837973.EqbrSDaRnS@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox