Re: [B.A.T.M.A.N.] [PATCH v3 3/6] batman-adv: split tvlv into a separate file

Marek Lindner
2016-05-20T08:58:01Z

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

On Sunday, May 15, 2016 11:07:43 Sven Eckelmann wrote:
> From: Markus Pargmann <mpa@pengutronix.de>
>
> The tvlv functionality in main.c is mostly unrelated to the rest of the
> content. It still takes up a large portion of this source file (~45%, 588
> lines). Moving it to a separate file makes it better visible as a main
> component of the batman-adv implementation and hides it less in the other
> helper functions in main.c
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> [sven@narfation.org: fix conflicts with current version, fix includes,
> rewrote commit message]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v3:
> - Patch was resurrected from https://patchwork.open-mesh.org/patch/4244/
> - rewrote commit message
> - fixed conflicts
> - fixed includes
> ---
> net/batman-adv/Makefile | 1 +
> net/batman-adv/bat_iv_ogm.c | 1 +
> net/batman-adv/bat_v_ogm.c | 1 +
> net/batman-adv/distributed-arp-table.c | 1 +
> net/batman-adv/gateway_common.c | 1 +
> net/batman-adv/main.c | 591
> -------------------------------
> net/batman-adv/main.h | 34 --
> net/batman-adv/multicast.c | 1 +
> net/batman-adv/network-coding.c | 1 +
> net/batman-adv/routing.c | 1 +
> net/batman-adv/translation-table.c | 1 +
> net/batman-adv/tvlv.c | 630
> +++++++++++++++++++++++++++++++++
> net/batman-adv/tvlv.h | 61 ++++
> 13 files changed, 700 insertions(+), 625 deletions(-)
> create mode 100644 net/batman-adv/tvlv.c
> create mode 100644 net/batman-adv/tvlv.h

Applied in revision 65326e3.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]