From: Sven Eckelmann <sven@narfation.org>
To: Andreas Pape <APape@phoenixcontact.com>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] Antwort: Re: [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla
Date: Sat, 27 Feb 2016 12:31:05 +0100 [thread overview]
Message-ID: <2909292.ZAgPzXvjgZ@sven-edge> (raw)
In-Reply-To: <OF34C428B5.B1B9DB61-ONC1257F66.00389705-C1257F66.003D570A@phoenixcontact.com>
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
On Saturday 27 February 2016 12:10:00 Andreas Pape wrote:
> Is there a way to generate the cover letter also with git send-email? As I
> did
> not know how to generate it, I used claws as a separate e-mail client.
I've already explained this earlier [1]:
git send-email --compose 0001-.... 0002-... ....
The --compose option should force git-send-email to open an $EDITOR which then
can be used to write a separate message. But you can also just create manually
a 0000-* file with the same valid mail headers (like the ones in a patch
generated by git-format-patch) and add it as first file to `git send-email`.
> I used checkpatch.pl of linux 4.5 rc5 and checked each patch seperately
> without open
> issues. These things with bracket alignment etc. start driving me crazy.
> Looks as if I don't
> use a proper editor. Can you recommend one to use before sending patches?
Every editor which can be configured to represent one tab as 8 spaces. I
personally use kate or vim.
You should use checkpatch.pl with --strict. And you can also try to check the
original source file with bracket_align.py [2]. Btw. I personally use
checkpatch.pl from linux-next [3] because it usually has some new checks
which are not yet in Linus' tree.
Kind regards,
Sven
[1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-February/014491.html
[2] https://git.open-mesh.org/build_test.git/blob_plain/HEAD:/testhelpers/bracket_align.py
[3] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-27 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 13:16 [B.A.T.M.A.N.] [Patchv2 0/7] batman-adv: Optimizations for setups running dat and bla Andreas Pape
2016-02-26 16:20 ` Sven Eckelmann
2016-02-27 11:10 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2016-02-27 11:31 ` Sven Eckelmann [this message]
2016-02-27 11:33 ` Andreas Pape
2016-02-27 11:40 ` Sven Eckelmann
2016-03-01 16:09 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2909292.ZAgPzXvjgZ@sven-edge \
--to=sven@narfation.org \
--cc=APape@phoenixcontact.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox