Re: [B.A.T.M.A.N.] [RFC] batman-adv: prevent TT request storms by not sending inconsistent TT TLVLs

Sven Eckelmann
2018-05-09T18:20:58Z

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On Mittwoch, 9. Mai 2018 19:21:32 CEST Sven Eckelmann wrote:
[...]
> [...]
> > diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
> > index 0225616d..def8d109 100644
> > --- a/net/batman-adv/translation-table.c
> > +++ b/net/batman-adv/translation-table.c
> > @@ -855,7 +855,8 @@ batadv_tt_prepare_tvlv_global_data(struct batadv_orig_node *orig_node,
>
> What about batadv_tt_prepare_tvlv_local_data?

Let me rephrase that: Are we sure that this is from intermediate nodes or is
there still the possibility that it is from the actual originator? Regarding
the latter: Should batadv_tt_prepare_tvlv_local_data be modified or will you
wait for Leonardo to debug why it happens in the first place?

Kind regards,
Sven