public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add compat code for BUILD_BUG_ON_NOT_POWER_OF_2
@ 2016-01-20 18:00 Sven Eckelmann
  2016-01-30  4:17 ` Marek Lindner
  0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2016-01-20 18:00 UTC (permalink / raw)
  To: b.a.t.m.a.n; +Cc: Sven Eckelmann

Fixes: 2c2fe0ba9ea5 ("batman-adv: ELP - creating neighbor structures")
Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
---
v2:
 - add missing include in average.h which is required to always defined
   BUILD_BUG_ON_NOT_POWER_OF_2 correctly

 compat-include/linux/average.h |  2 ++
 compat-include/linux/bug.h     | 13 +++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/compat-include/linux/average.h b/compat-include/linux/average.h
index e5a2bf5..631df9b 100644
--- a/compat-include/linux/average.h
+++ b/compat-include/linux/average.h
@@ -26,6 +26,8 @@
 #include_next <linux/average.h>
 #endif
 
+#include <linux/bug.h>
+
 #if LINUX_VERSION_CODE < KERNEL_VERSION(4, 3, 0)
 
 /* Exponentially weighted moving average (EWMA) */
diff --git a/compat-include/linux/bug.h b/compat-include/linux/bug.h
index 124fd28..0c46158 100644
--- a/compat-include/linux/bug.h
+++ b/compat-include/linux/bug.h
@@ -24,6 +24,19 @@
 #include <linux/version.h>
 #include_next <linux/bug.h>
 
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 33)
+
+#undef BUILD_BUG_ON_NOT_POWER_OF_2
+#ifdef __CHECKER__
+#define BUILD_BUG_ON_NOT_POWER_OF_2(n) (0)
+#else
+/* Force a compilation error if a constant expression is not a power of 2 */
+#define BUILD_BUG_ON_NOT_POWER_OF_2(n) \
+	BUILD_BUG_ON((n) == 0 || (((n) & ((n) - 1)) != 0))
+#endif
+
+#endif /* < KERNEL_VERSION(2, 6, 33) */
+
 #if LINUX_VERSION_CODE < KERNEL_VERSION(3, 0, 0)
 
 #undef BUILD_BUG_ON
-- 
2.7.0.rc3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add compat code for BUILD_BUG_ON_NOT_POWER_OF_2
  2016-01-20 18:00 [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add compat code for BUILD_BUG_ON_NOT_POWER_OF_2 Sven Eckelmann
@ 2016-01-30  4:17 ` Marek Lindner
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2016-01-30  4:17 UTC (permalink / raw)
  To: b.a.t.m.a.n; +Cc: Sven Eckelmann

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On Wednesday, January 20, 2016 19:00:15 Sven Eckelmann wrote:
> Fixes: 2c2fe0ba9ea5 ("batman-adv: ELP - creating neighbor structures")
> Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
> ---
> v2:
>  - add missing include in average.h which is required to always defined
>    BUILD_BUG_ON_NOT_POWER_OF_2 correctly
> 
>  compat-include/linux/average.h |  2 ++
>  compat-include/linux/bug.h     | 13 +++++++++++++
>  2 files changed, 15 insertions(+)

Applied in revision a23e9a9.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-30  4:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-20 18:00 [B.A.T.M.A.N.] [PATCH v2] batman-adv: Add compat code for BUILD_BUG_ON_NOT_POWER_OF_2 Sven Eckelmann
2016-01-30  4:17 ` Marek Lindner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox