From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org, "Petr Štetiar" <ynezz@true.cz>
Subject: Re: [B.A.T.M.A.N.] [PATCH-maint] batman-adv: lock crc access in bridge loop avoidance
Date: Fri, 11 Sep 2015 17:43:48 +0200 [thread overview]
Message-ID: <3031965.xR9RMR6qaB@prime> (raw)
In-Reply-To: <20150911151956.GF19674@ibawizard.net>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Friday 11 September 2015 17:19:56 Petr Å tetiar wrote:
> Hi,
>
> Simon Wunderlich <sw@simonwunderlich.de> [2015-09-11 16:12:03]:
> > @@ -1669,11 +1685,15 @@ int batadv_bla_claim_table_seq_print_text(struct
> > seq_file *seq, void *offset)>
> > hlist_for_each_entry_rcu(claim, head, hash_entry) {
> >
> > is_own = batadv_compare_eth(claim->backbone_gw->orig,
> >
> > primary_addr);
> >
> > +
> > + spin_lock_bh(&claim->backbone_gw->crc_lock);
> > + backbone_crc = claim->backbone_gw->crc;
> > + spin_lock_bh(&claim->backbone_gw->crc_lock);
>
> shouldn't this be spin_unlock_bh?
Oh my, good catch! Yes, that's right!! I'll send a revised version!
Thanks,
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2015-09-11 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 14:12 [B.A.T.M.A.N.] [PATCH-maint] batman-adv: lock crc access in bridge loop avoidance Simon Wunderlich
2015-09-11 15:19 ` Petr Štetiar
2015-09-11 15:43 ` Simon Wunderlich [this message]
2015-09-11 15:38 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3031965.xR9RMR6qaB@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox