From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH 1/3] batman-adv: bcast: queue per interface, if needed
Date: Sat, 25 May 2019 12:21:32 +0200 [thread overview]
Message-ID: <3044203.LVLg11BY96@sven-edge> (raw)
In-Reply-To: <20190514073859.2053-2-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On Tuesday, 14 May 2019 09:38:57 CEST Linus Lüssing wrote:
> which we only broadcast on once the queueing induces an unncessary
unnecessary
> /**
> * batadv_forw_packet_bcasts_left() - check if a retransmission is necessary
> * @forw_packet: the forwarding packet to check
> @@ -811,28 +1031,20 @@ int batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,
> * Return: True if (re)transmissions are left, false otherwise.
> */
> static bool
> -batadv_forw_packet_bcasts_left(struct batadv_forw_packet *forw_packet,
> - struct batadv_hard_iface *hard_iface)
> +batadv_forw_packet_bcasts_left(struct batadv_forw_packet *forw_packet)
/home/sven/tmp/qemu-batman/batman-adv/net/batman-adv/send.c:1191: warning: Excess function parameter 'hard_iface' description in 'batadv_forw_packet_bcasts_left'
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-25 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:38 [PATCH 0/3] batman-adv: broadcast flooding improvements Linus Lüssing
2019-05-14 7:38 ` [PATCH 1/3] batman-adv: bcast: queue per interface, if needed Linus Lüssing
2019-05-25 10:21 ` Sven Eckelmann [this message]
2019-05-14 7:38 ` [PATCH 2/3] batman-adv: allow broadcast packet type with unicast destination Linus Lüssing
2019-05-25 10:02 ` Sven Eckelmann
2019-05-25 10:24 ` Sven Eckelmann
2019-05-25 10:53 ` Sven Eckelmann
2019-05-14 7:38 ` [PATCH 3/3] batman-adv: forward broadcast packets via unicast transmissions Linus Lüssing
2019-05-25 10:21 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3044203.LVLg11BY96@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox