From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sven Eckelmann Subject: Re: [PATCH v2 1/5] batman-adv: mcast: remove now redundant single ucast forwarding Date: Mon, 26 Dec 2022 18:09:11 +0100 Message-ID: <3060990.e9J7NaK4W3@sven-l14> In-Reply-To: <20221226161554.9657-2-linus.luessing@c0d3.blue> References: <20221226161554.9657-1-linus.luessing@c0d3.blue> <20221226161554.9657-2-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3405950.aeNJFYEL58"; micalg="pgp-sha512"; protocol="application/pgp-signature" Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: To: b.a.t.m.a.n@lists.open-mesh.org Cc: Linus =?ISO-8859-1?Q?L=FCssing?= --nextPart3405950.aeNJFYEL58 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org Cc: Linus =?ISO-8859-1?Q?L=FCssing?= Date: Mon, 26 Dec 2022 18:09:11 +0100 Message-ID: <3060990.e9J7NaK4W3@sven-l14> In-Reply-To: <20221226161554.9657-2-linus.luessing@c0d3.blue> MIME-Version: 1.0 On Monday, 26 December 2022 17:15:50 CET Linus L=FCssing wrote: > The multicast code to send a multicast packet via multiple batman-adv > unicast packets is not only capable of sending to multiple but also to a > single node. Therefore we can safely remove the old, specialized, now > redundant multicast-to-single-unicast code. >=20 > The only functional change of this simplification is that the edge case > of allowing a multicast packet with an unsnoopable destination address > (224.0.0.0/24 or ff02::1) where only a single node has signaled interest > in it via the batman-adv want-all-unsnoopables multicast flag is now > transmitted via a batman-adv broadcast instead of a batman-adv unicast > packet. Maintaining this edge case feature does not seem worth the extra > lines of code and people should just not expect to be able to snoop and > optimize such unsnoopable multicast addresses when bridges are involved. >=20 > While at it also renaming a few items in the batadv_forw_mode enum to > prepare for the new batman-adv multicast packet type. >=20 > Signed-off-by: Linus L=FCssing > --- > net/batman-adv/multicast.c | 248 ++------------------------------ > net/batman-adv/multicast.h | 38 +---- > net/batman-adv/soft-interface.c | 25 ++-- > 3 files changed, 33 insertions(+), 278 deletions(-) Output of different failed tests =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D ecsv/pu: headers =2D--------------- diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c index 89ba1093..6f387e61 100644 --- a/net/batman-adv/multicast.c +++ b/net/batman-adv/multicast.c @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-inte= rface.c index c2fa0ef5..cd04ab27 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -48,7 +48,6 @@ #include "hard-interface.h" #include "multicast.h" #include "network-coding.h" -#include "originator.h" #include "send.h" #include "translation-table.h" --nextPart3405950.aeNJFYEL58 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmOp1TcACgkQXYcKB8Em e0YTShAAkn/nAt8Rw+GJGKo71skBzBirLYuCCuM4O7ZxRw318BrqGZjGURSXf+9W U3jVzXlJuM/4N76SRIgD4idYTIg9ix3s7/s9AHdXnV51+hO0i5cMM2jP+c2RX+UB p4wETyay6av1xLK2kktlyVD0E5GLtQjC1Ziu8NghU8hkBNRS9Tc3BleH670Ny23J RR3QtuSV3h2KC3r2cfSSgP/P7KZs0lxm0EPNHS1LcIxIjL1zhqBLgu8D375RIybT CjQ/8QJO+JOnWBtRnqsp6DPwE50vyGYGkeItyEvnvP6SGldiLurv4GKvRMRAWFDo o0d9+OQRXnLH3252xCFt/u1KS9qvD59hEpv2o5Nx77SnHcW+vydLOefiGRokGryE W4KtsK2Dy1lGOZtHp31BNXVAKzj/aigoprMdEWaYtDJXU94FHkMQZdf8Y3YssTDl OcRcC2dnL8bmCTBSu59oxtRqyzjqWkkvONiZGmEgsucMyr9R6WHm01Q6NKz8FPOk VpvLhT6/nwh6XDTcMuGo/MTpj378UYOVwWK4bExXeD8VUkMSN22ov4y+zTYYBvzX qsjxR2l68A525kNx1zMYcVdC2Zkt8xIM46hJqbrIs+KzCauSx6HNxI1WxOakUkTi ++GElYnJzCSIM+agLCG8qsxleHdxiqffO2/wKLdHLxJzFWUPf1s= =1lqV -----END PGP SIGNATURE----- --nextPart3405950.aeNJFYEL58--