[B.A.T.M.A.N.] [PATCH] alfred: Keep order of interfaces from commandline

[B.A.T.M.A.N.] [PATCH] alfred: Keep order of interfaces from commandline

[Sven Eckelmann]

The first (valid) interface mac address will be used as source mac for an
dataset. But alfred added the commandline parameters for a multi-interface
master in reverse order.

Keep the list in the same order as the commandline to fulfill the
user expectations when checking the source entries of datasets.

Signed-off-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
---
 netsock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/netsock.c b/netsock.c
index d72541e..5d37347 100644
--- a/netsock.c
+++ b/netsock.c
@@ -165,7 +165,7 @@ int netsock_set_interfaces(struct globals *globals, char *interfaces)
 			return -ENOMEM;
 		}
 
-		list_add(&interface->list, &globals->interfaces);
+		list_add_tail(&interface->list, &globals->interfaces);
 	}
 
 	return 0;

Re: [B.A.T.M.A.N.] [PATCH] alfred: Keep order of interfaces from commandline

[Simon Wunderlich]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On Thursday, October 13, 2016 11:03:10 AM CEST Sven Eckelmann wrote:
> The first (valid) interface mac address will be used as source mac for an
> dataset. But alfred added the commandline parameters for a multi-interface
> master in reverse order.
> 
> Keep the list in the same order as the commandline to fulfill the
> user expectations when checking the source entries of datasets.
> 
> Signed-off-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>

Applied in revision f21f747

Thanks!
     Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]