Re: [B.A.T.M.A.N.] [PATCH] list: fix order of arguments for hlist_add_after(_rcu)

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

On Friday 15 August 2014 13:38:47 Sven Eckelmann wrote:
> From: Ken Helias <kenhelias@firemail.de>
> 
> All other add functions for lists have the new item as first argument
> and the position where it is added as second argument.  This was changed
> for no good reason in this function and makes using it unnecessary
> confusing.
> 
> The name was changed to hlist_add_behind() to cause unconverted code to
> generate a compile error instead of using the wrong parameter order.
> 
> [akpm@linux-foundation.org: coding-style fixes]
> Signed-off-by: Ken Helias <kenhelias@firemail.de>
> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>    [intel driver bits]
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> [sven@narfation.org: fix parameter order, add compat code]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> The patch to fix the order of arguments was already submitted to davem via
> http://article.gmane.org/gmane.linux.network/326598
> 
>  compat.h        | 6 ++++++
>  fragmentation.c | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)

Applied in revision 8353fd1.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]