From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH-maint] batman-adv: Fix ICMP RR ethernet access after skb_linearize
Date: Mon, 06 Jun 2016 23:35:22 +0800 [thread overview]
Message-ID: <3104087.nWbZjg80UC@voltaire> (raw)
In-Reply-To: <1464549952-27830-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Sunday, May 29, 2016 21:25:52 Sven Eckelmann wrote:
> The skb_linearize may reallocate the skb. This makes the calculated pointer
> for ethhdr invalid. But it the pointer is used later to fill in the RR
> field of the batadv_icmp_packet_rr packet.
>
> Instead re-evaluate eth_hdr after the skb_linearize+skb_cow to fix the
> pointer and avoid the invalid read.
>
> Fixes: bb69cb678d37 ("batman-adv: generalize batman-adv icmp packet
> handling") Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> net/batman-adv/routing.c | 1 +
> 1 file changed, 1 insertion(+)
Applied in revision f6c80c2.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-06-06 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 19:25 [B.A.T.M.A.N.] [PATCH-maint] batman-adv: Fix ICMP RR ethernet access after skb_linearize Sven Eckelmann
2016-06-06 15:35 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3104087.nWbZjg80UC@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox