From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: Re: [PATCH v2] batman-adv: bcast: queue per interface, if needed
Date: Fri, 14 May 2021 10:28:53 +0200 [thread overview]
Message-ID: <3148825.KiqjeL1upR@sven-desktop> (raw)
In-Reply-To: <20210427184527.9889-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Tuesday, 27 April 2021 20:45:27 CEST Linus Lüssing wrote:
> - * The skb is not consumed, so the caller should make sure that the
> - * skb is freed.
> + * This call clones the given skb, hence the caller needs to take into
> + * account that the data segment of the original skb might not be
> + * modifiable anymore.
But none of your callers is now taking care of it because you've removed all
skb_copy's. All you do is to clone the control data and give it to the
underlying layers. And they may write freely to the data. Thus breaking
parallel (and under some circumstances sequential) running code which operates
on the skbs.
The review was stopped after noticing this problem.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-14 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 18:45 [PATCH v2] batman-adv: bcast: queue per interface, if needed Linus Lüssing
2021-05-14 8:28 ` Sven Eckelmann [this message]
2021-05-14 11:35 ` Linus Lüssing
2021-05-14 11:52 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3148825.KiqjeL1upR@sven-desktop \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=linus.luessing@c0d3.blue \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox