From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/6] alfred: Reduce MAX_PAYLOAD by the size of the UDP header
Date: Mon, 01 Jun 2015 19:56:10 +0200 [thread overview]
Message-ID: <3154893.LhzU0btcuo@prime> (raw)
In-Reply-To: <1433072160-3260-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Sunday 31 May 2015 13:35:55 Sven Eckelmann wrote:
> The len field in the UDP header is 16 bit long. It can therefore store a
> value of up to (2 ** 16 - 1). This value is currently used for MAX_PAYLOAD.
> But the UDP len field not only stores the payload length but also the udp
> header itself. Thus the length of MAX_PAYLOAD has to be reduced by the
> size of udphdr to make sure that the payload can still be sent.
>
> Reported-by: Hans-Werner Hilse <hwhilse@gmail.com>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
Applied the whole series with the alternative wording for Patch 2.
Thanks!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2015-06-01 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 11:35 [B.A.T.M.A.N.] [PATCH 1/6] alfred: Reduce MAX_PAYLOAD by the size of the UDP header Sven Eckelmann
2015-05-31 11:35 ` [B.A.T.M.A.N.] [PATCH 2/6] alfred: Make buffer size check before sending explicit Sven Eckelmann
2015-06-01 17:23 ` Sven Eckelmann
2015-05-31 11:35 ` [B.A.T.M.A.N.] [PATCH 3/6] alfred: Don't push data when nothing is available Sven Eckelmann
2015-05-31 11:35 ` [B.A.T.M.A.N.] [PATCH 4/6] alfred: Check buffer size before pushing data over unix socket Sven Eckelmann
2015-05-31 11:35 ` [B.A.T.M.A.N.] [PATCH 5/6] alfred: First check only push_data header length Sven Eckelmann
2015-05-31 11:36 ` [B.A.T.M.A.N.] [PATCH 6/6] alfred: Drop small push_data packets early Sven Eckelmann
2015-06-01 17:56 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3154893.LhzU0btcuo@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox