From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: export compatibility version via debugfs
Date: Tue, 16 Oct 2012 02:09:23 +0200 [thread overview]
Message-ID: <32156311.f7ZhntrIpV@bentobox> (raw)
In-Reply-To: <1350244981-14026-2-git-send-email-ordex@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On Sunday 14 October 2012 22:03:01 Antonio Quartulli wrote:
> Different versions of the batman-adv module may use the same compatibility
> version, but this is not understandable at runtime (the only way is to parse
> the kernel log and fetch the batman-adv advertisement message on loading).
> The user may want to know whether two nodes using different versions can
> communicate or not. For this purpose the module has to export this value
> through debugfs.
>
> Reported-by: Moritz Warning <moritzwarning@web.de>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
[...]
> +/**
> + * batadv_compat_seq_print_text - print the compatibility version
> + * @seq: not used
> + * @offset: not used
> + */
> +int batadv_compat_seq_print_text(struct seq_file *seq, void *offset)
> +{
> + seq_printf(seq, "%d\n", BATADV_COMPAT_VERSION);
> +
> + return 0;
> +}
> +
seq is not used? Marek also segfaulted after reading this.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-16 0:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 20:03 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: support array of debugfs general attributes Antonio Quartulli
2012-10-14 20:03 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: export compatibility version via debugfs Antonio Quartulli
2012-10-14 20:05 ` Antonio Quartulli
2012-10-16 0:09 ` Sven Eckelmann [this message]
2012-10-16 6:07 ` Antonio Quartulli
2012-10-16 0:08 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: support array of debugfs general attributes Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32156311.f7ZhntrIpV@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox