From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: use eth_hdr() instead of skb->data in interface_tx path
Date: Sat, 18 Jan 2014 15:07:22 +0800 [thread overview]
Message-ID: <3247874.1xp1UKXXkF@diderot> (raw)
In-Reply-To: <1390013833-9364-1-git-send-email-linus.luessing@web.de>
[-- Attachment #1: Type: text/plain, Size: 666 bytes --]
On Saturday 18 January 2014 03:57:13 Linus Lüssing wrote:
> Using eth_hdr() instead of skb->data avoids some ugly type casts.
>
> I wasn't able to reproduce the skb ether header pointer mismatch
> mentioned in batadv_bla_tx() on a 3.11 kernel with a vlan on top of
> bat0 and therefore removed the according skb_reset_mac_header()
> call, too. In fact, it looks like it became obsolete with the following
> commit, included since 3.9:
>
> "net: reset mac header in dev_start_xmit()" (6d1ccff627)
Maybe this falls into nitpicking but it sounds like 2 entirely different things
for which you could send 2 patches (twice the fame!) ?
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2014-01-18 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 2:57 [B.A.T.M.A.N.] [PATCHv3] batman-adv: use eth_hdr() instead of skb->data in interface_tx path Linus Lüssing
2014-01-18 7:07 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3247874.1xp1UKXXkF@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox