From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support
Date: Sun, 31 Jan 2016 14:26:27 +0100 [thread overview]
Message-ID: <3255100.5LmjYr8IdZ@sven-edge> (raw)
In-Reply-To: <1453312110-32683-1-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 3737 bytes --]
On Wednesday 20 January 2016 18:48:26 Andrew Lunn wrote:
[...]
> Andrew Lunn (4):
> batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves
> batman-adv: Create batman soft interfaces within correct netns.
> batman-adv: Handle parent interfaces in a different netns
> batman-adv: debugfs: Add netns support
>
> net/batman-adv/debugfs.c | 118
> ++++++++++++++++++++++++++++++++++++- net/batman-adv/hard-interface.c |
> 49 +++++++++++++--
> net/batman-adv/hard-interface.h | 2 +-
> net/batman-adv/soft-interface.c | 9 ++-
> net/batman-adv/soft-interface.h | 2 +-
> net/batman-adv/sysfs.c | 3 +-
> net/batman-adv/translation-table.c | 3 +-
> 7 files changed, 172 insertions(+), 14 deletions(-)
Just to let everybody know: This patchset will break batman-adv compatibility
for kernels older than 4.0 (see d37512a277dfb2cef8a578e25a3246f61399a55a):
hard-interface.c:105:55: error: no member 'get_link_net' in struct rtnl_link_ops
hard-interface.c:106:54: error: no member 'get_link_net' in struct rtnl_link_ops
hard-interface.c:107:55: error: no member 'get_link_net' in struct rtnl_link_ops
hard-interface.c:108:54: error: no member 'get_link_net' in struct rtnl_link_ops
hard-interface.c:148:61: error: no member 'get_link_net' in struct rtnl_link_ops
hard-interface.c:149:52: error: no member 'get_link_net' in struct rtnl_link_ops
hard-interface.c: In function 'batadv_mutual_parents':
hard-interface.c:105:48: error: 'const struct rtnl_link_ops' has no member named 'get_link_net'
if (dev1->rtnl_link_ops && dev1->rtnl_link_ops->get_link_net)
^
hard-interface.c:106:40: error: 'const struct rtnl_link_ops' has no member named 'get_link_net'
dev1_parent_net = dev1->rtnl_link_ops->get_link_net(dev1);
^
hard-interface.c:107:48: error: 'const struct rtnl_link_ops' has no member named 'get_link_net'
if (dev2->rtnl_link_ops && dev2->rtnl_link_ops->get_link_net)
^
hard-interface.c:108:40: error: 'const struct rtnl_link_ops' has no member named 'get_link_net'
dev2_parent_net = dev2->rtnl_link_ops->get_link_net(dev2);
^
hard-interface.c: In function 'batadv_is_on_batman_iface':
hard-interface.c:148:54: error: 'const struct rtnl_link_ops' has no member named 'get_link_net'
if (net_dev->rtnl_link_ops && net_dev->rtnl_link_ops->get_link_net)
^
hard-interface.c:149:38: error: 'const struct rtnl_link_ops' has no member named 'get_link_net'
parent_net = net_dev->rtnl_link_ops->get_link_net(net_dev);
^
make[2]: *** [hard-interface.o] Error 1
make[1]: *** [_module_] Error 2
make: *** [all] Error 2
(build stopped here and there may be a lot more problems)
And with 3.18 you will only get until (see
435d5f4bb2ccba3b791d9ef61d2590e30b8e806e):
debugfs.c:87:40: error: no member 'ns' in struct net
debugfs.c:547:37: error: no member 'ns' in struct net
debugfs.c: In function 'batadv_debugfs_ns_get':
debugfs.c:87:26: error: 'struct net' has no member named 'ns'
sprintf(name, "%u", net->ns.inum);
^
debugfs.c: In function 'batadv_debugfs_init':
debugfs.c:547:30: error: 'struct net' has no member named 'ns'
sprintf(name, "%u", init_net.ns.inum);
^
make[2]: *** [debugfs.o] Error 1
make[1]: *** [_module_] Error 2
make: *** [all] Error 2
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-31 13:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:48 [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support Andrew Lunn
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 1/4] batman-adv: NETIF_F_NETNS_LOCAL feature to prevent netns moves Andrew Lunn
2016-01-23 2:06 ` Antonio Quartulli
2016-01-23 17:20 ` Andrew Lunn
2016-01-24 6:19 ` Antonio Quartulli
2016-01-24 10:42 ` Antonio Quartulli
2016-01-24 16:46 ` Andrew Lunn
2016-01-24 11:01 ` Antonio Quartulli
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: Create batman soft interfaces within correct netns Andrew Lunn
2016-01-25 3:28 ` Antonio Quartulli
2016-01-25 13:12 ` Andrew Lunn
2016-01-26 5:43 ` Antonio Quartulli
2016-01-26 5:55 ` Antonio Quartulli
2016-01-31 13:26 ` Sven Eckelmann
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 3/4] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-01-26 12:53 ` Antonio Quartulli
2016-01-26 13:25 ` Sven Eckelmann
2016-01-27 10:13 ` Sven Eckelmann
2016-01-27 10:44 ` Antonio Quartulli
2016-02-01 2:57 ` Antonio Quartulli
2016-02-02 2:11 ` Andrew Lunn
2016-01-31 13:26 ` Sven Eckelmann
2016-01-20 17:48 ` [B.A.T.M.A.N.] [PATCH 4/4] batman-adv: debugfs: Add netns support Andrew Lunn
2016-01-28 1:28 ` Antonio Quartulli
2016-01-28 1:40 ` Andrew Lunn
2016-01-28 2:29 ` Antonio Quartulli
2016-01-31 13:26 ` Sven Eckelmann
2016-01-28 2:59 ` [B.A.T.M.A.N.] [PATCH 0/4] batman-adv: Add network name space support Antonio Quartulli
2016-01-28 3:50 ` Andrew Lunn
2016-01-31 13:26 ` Sven Eckelmann [this message]
2016-02-12 15:57 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3255100.5LmjYr8IdZ@sven-edge \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox