From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [1/4] batctl: Replace list implementation with linux-like-list
Date: Tue, 18 Oct 2016 14:24:59 +0200 [thread overview]
Message-ID: <3320851.xE1M4ho6LC@bentobox> (raw)
In-Reply-To: <1468961051-6447-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
On Dienstag, 19. Juli 2016 22:44:08 CEST Sven Eckelmann wrote:
> The list-batman implementation of linked lists has an interface which tries
> to resample the linux double linked list implementation but in reality is
> incompatible. This resulted in code which moves most of the pointer
> arithmetic back to the actual code. This is rather unfortunate because this
> abstraction should reduce the pointer arithmetic and not increase it.
>
> Also the incompatibilities between the list implementation used in
> batman-adv and the one used by batctl made coding features in both
> components error prone because each component required a slightly different
> implementation for the same list manipulation.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Makefile | 1 -
> bisect_iv.c | 40 ++-
> bisect_iv.h | 10 +-
> list-batman.c | 123 ---------
> list-batman.h | 120 ---------
> list.h | 834
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tcpdump.c |
> 7 +-
> tcpdump.h | 2 +-
> 8 files changed, 860 insertions(+), 277 deletions(-)
> delete mode 100644 list-batman.c
> delete mode 100644 list-batman.h
> create mode 100644 list.h
Applied in 315b3b0fac147b9d8dc8f83a6409fde91eca683a [1].
Kind regards,
Sven
[1] https://git.open-mesh.org/batctl.git/commit/315b3b0fac147b9d8dc8f83a6409fde91eca683a
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-10-18 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 20:43 [B.A.T.M.A.N.] [PATCH 0/4] batctl: Userspace batadv_icmp endpoints Sven Eckelmann
2016-07-19 20:44 ` [B.A.T.M.A.N.] [PATCH 1/4] batctl: Replace list implementation with linux-like-list Sven Eckelmann
2016-10-18 12:24 ` Sven Eckelmann [this message]
2016-07-19 20:44 ` [B.A.T.M.A.N.] [PATCH 2/4] batctl: Use monotonic time source for icmp timing Sven Eckelmann
2016-10-18 12:25 ` [B.A.T.M.A.N.] [2/4] " Sven Eckelmann
2016-07-19 20:44 ` [B.A.T.M.A.N.] [PATCH 3/4] batctl: Add helper to generate instant random bytes Sven Eckelmann
2016-07-19 20:44 ` [B.A.T.M.A.N.] [PATCH 4/4] batctl: Implement non-routing batadv_icmp in userspace Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3320851.xE1M4ho6LC@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox