From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Split batadv_iv_ogm_orig_del_if function
Date: Sun, 28 Feb 2016 07:41:38 +0800 [thread overview]
Message-ID: <33875999.jBEq8r4P9a@voltaire> (raw)
In-Reply-To: <1456178194-29307-2-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
On Monday, February 22, 2016 22:56:34 Sven Eckelmann wrote:
> batadv_iv_ogm_orig_del_if handles two different buffers bcast_own and
> bcast_own_sum which should be resized. The error handling two for
> allocating these buffers causes the complexity of this function. This can
> be avoided completely when the function is split into a main function
> handling the locking, freeing and call of the subfunctions.
>
> The subfunction can then independently handle the resize of the buffers.
> This also allows to easily reuse the old buffer (which always is larger) in
> case a smaller buffer could not be allocated without increasing the code
> complexity.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> net/batman-adv/bat_iv_ogm.c | 131
> ++++++++++++++++++++++++++++---------------- 1 file changed, 84
> insertions(+), 47 deletions(-)
Applied in revision 1c5fc73.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-27 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 21:56 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix unexpected free of bcast_own on add_if error Sven Eckelmann
2016-02-22 21:56 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Split batadv_iv_ogm_orig_del_if function Sven Eckelmann
2016-02-27 23:41 ` Marek Lindner [this message]
2016-02-27 23:33 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix unexpected free of bcast_own on add_if error Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33875999.jBEq8r4P9a@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox