From: Sven Eckelmann <sven@narfation.org>
To: Felix Kaechele <felix@kaechele.ca>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH] batman-adv: compat: Fix build on RHEL 8.1 and clones
Date: Sat, 25 Jan 2020 20:17:30 +0100 [thread overview]
Message-ID: <3489864.0R65RLHByN@sven-edge> (raw)
In-Reply-To: <20200125180745.19517-1-felix@kaechele.ca>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Saturday, 25 January 2020 19:07:45 CET Felix Kaechele wrote:
> RHEL 8.1 backported some fixes from newer kernels so we need to treat it's 4.18
> kernel as if it were a newer kernel in some cases.
I am personally not really happy about supporting all kind of weird Linux
kernel forks.
Anyway, if you really want to maintain the RHEL support (for reasonable
versions which are based on reasonable new upstream kernels) then I would
propose to avoid this RHEL_81. Instead it might be better to just add
RHEL_RELEASE_VERSION + RHEL_RELEASE_CODE [1] to
compat-include/linux/version.h. And then just use them like the backports.git
is using them [2].
Kind regards,
Sven
[1] https://git.kernel.org/pub/scm/linux/kernel/git/backports/backports.git/tree/backport/backport-include/linux/version.h?id=368e8c51a59629ea7d681f5b96d4f5a9f89ad1a6#n140
[2] https://git.kernel.org/pub/scm/linux/kernel/git/backports/backports.git/tree/backport/backport-include/linux/skbuff.h?id=368e8c51a59629ea7d681f5b96d4f5a9f89ad1a6#n140
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-25 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 18:07 [PATCH] batman-adv: compat: Fix build on RHEL 8.1 and clones Felix Kaechele
2020-01-25 19:17 ` Sven Eckelmann [this message]
2020-01-28 17:19 ` Felix Kaechele
2020-01-28 17:32 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3489864.0R65RLHByN@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=felix@kaechele.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox