Re: [B.A.T.M.A.N.] [PATCH 09/10] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink

Sven Eckelmann
2016-04-29T20:36:41Z

[-- Attachment #1.1: Type: text/plain, Size: 2497 bytes --]

=2D-nextPart182747217.0FVkfQt3I0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Friday 29 April 2016 21:15:20 Sven Eckelmann wrote:
> On Thursday 28 April 2016 22:37:27 Andrew Lunn wrote:
> > Dump the list of gateways via the netlink socket.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >
> > include/uapi/linux/batman_adv.h | 4 ++
> > net/batman-adv/gateway_client.c | 126
> >
> > ++++++++++++++++++++++++++++++++++++++++ net/batman-adv/gateway_client.h |
> >
> > 1 +
> > net/batman-adv/netlink.c | 7 +++
> > 4 files changed, 138 insertions(+)
>
> You can find the missing includes in the attached patch

There were more missing in gateway_client.c. See attached patch

Kind regards,
Sven
=2D-nextPart182747217.0FVkfQt3I0
Content-Disposition: attachment; filename="0018-missing-includes-9.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0018-missing-includes-9.patch"

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 21:05:29 +0200
Subject: [PATCH] missing includes 9
=2D--
net/batman-adv/gateway_client.c | 5 +++++
net/batman-adv/gateway_client.h | 1 +
2 files changed, 6 insertions(+)

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 4e8525d..655849a 100644
=2D-- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -21,6 +21,7 @@
#include <linux/atomic.h>
#include <linux/byteorder/generic.h>
#include <linux/etherdevice.h>
+#include <linux/errno.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
@@ -31,6 +32,7 @@
#include <linux/kref.h>
#include <linux/list.h>
#include <linux/netdevice.h>
+#include <linux/netlink.h>
#include <linux/rculist.h>
#include <linux/rcupdate.h>
#include <linux/seq_file.h>
@@ -39,6 +41,9 @@
#include <linux/spinlock.h>
#include <linux/stddef.h>
#include <linux/udp.h>
+#include <net/genetlink.h>
+#include <net/netlink.h>
+#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

#include "gateway_common.h"
diff --git a/net/batman-adv/gateway_client.h b/net/batman-adv/gateway_client.h
index 294ff09..f1b2d39 100644
=2D-- a/net/batman-adv/gateway_client.h
+++ b/net/batman-adv/gateway_client.h
@@ -23,6 +23,7 @@
#include <linux/types.h>

struct batadv_tvlv_gateway_data;
+struct netlink_callback;
struct seq_file;
struct sk_buff;

=2D-nextPart182747217.0FVkfQt3I0--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 651 bytes --]

On Friday 29 April 2016 21:15:20 Sven Eckelmann wrote:
> On Thursday 28 April 2016 22:37:27 Andrew Lunn wrote:
> > Dump the list of gateways via the netlink socket.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> >
> > include/uapi/linux/batman_adv.h | 4 ++
> > net/batman-adv/gateway_client.c | 126
> >
> > ++++++++++++++++++++++++++++++++++++++++ net/batman-adv/gateway_client.h |
> >
> > 1 +
> > net/batman-adv/netlink.c | 7 +++
> > 4 files changed, 138 insertions(+)
>
> You can find the missing includes in the attached patch

There were more missing in gateway_client.c. See attached patch

Kind regards,
Sven

[-- Attachment #1.3: 0018-missing-includes-9.patch --]
[-- Type: text/x-patch, Size: 1425 bytes --]

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 21:05:29 +0200
Subject: [PATCH] missing includes 9
---
net/batman-adv/gateway_client.c | 5 +++++
net/batman-adv/gateway_client.h | 1 +
2 files changed, 6 insertions(+)

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 4e8525d..655849a 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -21,6 +21,7 @@
#include <linux/atomic.h>
#include <linux/byteorder/generic.h>
#include <linux/etherdevice.h>
+#include <linux/errno.h>
#include <linux/fs.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
@@ -31,6 +32,7 @@
#include <linux/kref.h>
#include <linux/list.h>
#include <linux/netdevice.h>
+#include <linux/netlink.h>
#include <linux/rculist.h>
#include <linux/rcupdate.h>
#include <linux/seq_file.h>
@@ -39,6 +41,9 @@
#include <linux/spinlock.h>
#include <linux/stddef.h>
#include <linux/udp.h>
+#include <net/genetlink.h>
+#include <net/netlink.h>
+#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

#include "gateway_common.h"
diff --git a/net/batman-adv/gateway_client.h b/net/batman-adv/gateway_client.h
index 294ff09..f1b2d39 100644
--- a/net/batman-adv/gateway_client.h
+++ b/net/batman-adv/gateway_client.h
@@ -23,6 +23,7 @@
#include <linux/types.h>

struct batadv_tvlv_gateway_data;
+struct netlink_callback;
struct seq_file;
struct sk_buff;