Re: [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: netlink: add translation table query

Sven Eckelmann
2016-04-29T19:15:07Z

[-- Attachment #1.1: Type: text/plain, Size: 3117 bytes --]

=2D-nextPart2158221.QS5XQXo8Tn
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday 28 April 2016 22:37:22 Andrew Lunn wrote:
> From: Matthias Schiffer <mschiffer@universe-factory.net>
>
> This adds the commands BATADV_CMD_GET_TRANSTABLE_LOCAL and
> BATADV_CMD_GET_TRANSTABLE_GLOBAL, which correspond to the transtable_local
> and transtable_global debugfs files.
>
> The batadv_tt_client_flags enum is moved to the UAPI to expose it as part
> of the netlink API.
>
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
> include/uapi/linux/batman_adv.h | 47 ++++++
> net/batman-adv/netlink.c | 12 ++
> net/batman-adv/packet.h | 36 -----
> net/batman-adv/translation-table.c | 305
> +++++++++++++++++++++++++++++++++++++ net/batman-adv/translation-table.h |
> 2 +
> 5 files changed, 366 insertions(+), 36 deletions(-)

You can find the missing includes in the attached patch

Kind regards,
Sven
=2D-nextPart2158221.QS5XQXo8Tn
Content-Disposition: attachment; filename="0009-missing-includes-4.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0009-missing-includes-4.patch"

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:47:26 +0200
Subject: [PATCH] missing includes 4
=2D--
net/batman-adv/netlink.c | 1 +
net/batman-adv/translation-table.c | 5 ++++-
net/batman-adv/translation-table.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 7309f18..3fb1c1f 100644
=2D-- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -35,6 +35,7 @@

#include "hard-interface.h"
#include "soft-interface.h"
+#include "translation-table.h"

struct genl_family batadv_netlink_family = {
.id = GENL_ID_GENERATE,
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index cd3e4f2..be42b12 100644
=2D-- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -35,15 +35,18 @@
#include <linux/list.h>
#include <linux/lockdep.h>
#include <linux/netdevice.h>
+#include <linux/netlink.h>
#include <linux/rculist.h>
#include <linux/rcupdate.h>
#include <linux/seq_file.h>
+#include <linux/skbuff.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/stddef.h>
#include <linux/string.h>
#include <linux/workqueue.h>
=2D#include <net/net_namespace.h>
+#include <net/genetlink.h>
+#include <net/netlink.h>
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

diff --git a/net/batman-adv/translation-table.h b/net/batman-adv/translation-table.h
index 6d8b5b2..7128fb3 100644
=2D-- a/net/batman-adv/translation-table.h
+++ b/net/batman-adv/translation-table.h
@@ -23,7 +23,9 @@
#include <linux/types.h>

struct net_device;
+struct netlink_callback;
struct seq_file;
+struct sk_buff;

int batadv_tt_init(struct batadv_priv *bat_priv);
bool batadv_tt_local_add(struct net_device *soft_iface, const u8 *addr,

=2D-nextPart2158221.QS5XQXo8Tn--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 880 bytes --]

On Thursday 28 April 2016 22:37:22 Andrew Lunn wrote:
> From: Matthias Schiffer <mschiffer@universe-factory.net>
>
> This adds the commands BATADV_CMD_GET_TRANSTABLE_LOCAL and
> BATADV_CMD_GET_TRANSTABLE_GLOBAL, which correspond to the transtable_local
> and transtable_global debugfs files.
>
> The batadv_tt_client_flags enum is moved to the UAPI to expose it as part
> of the netlink API.
>
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
> include/uapi/linux/batman_adv.h | 47 ++++++
> net/batman-adv/netlink.c | 12 ++
> net/batman-adv/packet.h | 36 -----
> net/batman-adv/translation-table.c | 305
> +++++++++++++++++++++++++++++++++++++ net/batman-adv/translation-table.h |
> 2 +
> 5 files changed, 366 insertions(+), 36 deletions(-)

You can find the missing includes in the attached patch

Kind regards,
Sven

[-- Attachment #1.3: 0009-missing-includes-4.patch --]
[-- Type: text/x-patch, Size: 1818 bytes --]

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:47:26 +0200
Subject: [PATCH] missing includes 4
---
net/batman-adv/netlink.c | 1 +
net/batman-adv/translation-table.c | 5 ++++-
net/batman-adv/translation-table.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 7309f18..3fb1c1f 100644
--- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -35,6 +35,7 @@

#include "hard-interface.h"
#include "soft-interface.h"
+#include "translation-table.h"

struct genl_family batadv_netlink_family = {
.id = GENL_ID_GENERATE,
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index cd3e4f2..be42b12 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -35,15 +35,18 @@
#include <linux/list.h>
#include <linux/lockdep.h>
#include <linux/netdevice.h>
+#include <linux/netlink.h>
#include <linux/rculist.h>
#include <linux/rcupdate.h>
#include <linux/seq_file.h>
+#include <linux/skbuff.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/stddef.h>
#include <linux/string.h>
#include <linux/workqueue.h>
-#include <net/net_namespace.h>
+#include <net/genetlink.h>
+#include <net/netlink.h>
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

diff --git a/net/batman-adv/translation-table.h b/net/batman-adv/translation-table.h
index 6d8b5b2..7128fb3 100644
--- a/net/batman-adv/translation-table.h
+++ b/net/batman-adv/translation-table.h
@@ -23,7 +23,9 @@
#include <linux/types.h>

struct net_device;
+struct netlink_callback;
struct seq_file;
+struct sk_buff;

int batadv_tt_init(struct batadv_priv *bat_priv);
bool batadv_tt_local_add(struct net_device *soft_iface, const u8 *addr,