Re: [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: Suppress debugfs entries for netns's

Sven Eckelmann
2016-04-29T18:07:18Z

[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]

On Thursday 28 April 2016 22:37:20 Andrew Lunn wrote:
> Debugfs is not netns aware. It thus has problems when the same
> interface name exists in multiple network name spaces.
>
> Work around this by not creating entries for interfaces in name spaces
> other than the default name space. This means meshes in network
> namespaces cannot be managed via debugfs, but there will soon be a
> netlink interface which is netns aware.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
[...]
> -__printf(2, 3)
> +_printf(2, 3)
> static int batadv_fdebug_log(struct batadv_priv_debug_log *debug_log,
> const char *fmt, ...)
> {

I would really like to give this patch a Reviewed-by but this part seems to be
an accident. It causes build errors:

$ make CONFIG_BATMAN_ADV_DEBUG=y KERNELPATH=/build_test/linux-build/linux-4.5
[...]
CC [M] /tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.o
/tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.c:81:9: error: expected declaration specifiers or ‘...’ before numeric constant
_printf(2, 3)
^
/tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.c:81:12: error: expected declaration specifiers or ‘...’ before numeric constant
_printf(2, 3)
^
/tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.c: In function ‘batadv_debug_log’:
/tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.c:114:2: error: implicit declaration of function ‘batadv_fdebug_log’ [-Werror=implicit-function-declaration]
batadv_fdebug_log(bat_priv->debug_log, "[%10u] %s",
^
/tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.c: At top level:
/tmp/qemu-batman/batman-adv/net/batman-adv/debugfs.c:68:13: warning: ‘batadv_emit_log_char’ defined but not used [-Wunused-function]
static void batadv_emit_log_char(struct batadv_priv_debug_log *debug_log,
^