Re: [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Handle parent interfaces in a different netns

Sven Eckelmann
2016-04-29T19:14:52Z

[-- Attachment #1.1: Type: text/plain, Size: 1762 bytes --]

=2D-nextPart2322509.dKPzMjGbIz
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday 28 April 2016 22:37:19 Andrew Lunn wrote:
> batman-adv tries to prevent the user from placing a batX soft
> interface into another batman mesh as a hard interface. It does this
> by walking up the devices list of parents and ensures they are all
> none batX interfaces. iflink can point to an interface in a different
> namespace, so also retrieve the parents name space when finding the
> parent and use it when doing the comparison.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Antonio Quartulli <a@untable.cc>
> ---
> net/batman-adv/hard-interface.c | 31 ++++++++++++++++++++++++-------
> 1 file changed, 24 insertions(+), 7 deletions(-)

You can find the missing includes in the attached patch

Kind regards,
Sven
=2D-nextPart2322509.dKPzMjGbIz
Content-Disposition: attachment; filename="0002-missing-includes-1.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0002-missing-includes-1.patch"

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:26:24 +0200
Subject: [PATCH] missing includes 1
=2D--
net/batman-adv/hard-interface.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index e0cd7ce..2dfbb84 100644
=2D-- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -36,6 +36,8 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/workqueue.h>
+#include <net/net_namespace.h>
+#include <net/rtnetlink.h>

#include "bridge_loop_avoidance.h"
#include "debugfs.h"

=2D-nextPart2322509.dKPzMjGbIz--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 748 bytes --]

On Thursday 28 April 2016 22:37:19 Andrew Lunn wrote:
> batman-adv tries to prevent the user from placing a batX soft
> interface into another batman mesh as a hard interface. It does this
> by walking up the devices list of parents and ensures they are all
> none batX interfaces. iflink can point to an interface in a different
> namespace, so also retrieve the parents name space when finding the
> parent and use it when doing the comparison.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Antonio Quartulli <a@untable.cc>
> ---
> net/batman-adv/hard-interface.c | 31 ++++++++++++++++++++++++-------
> 1 file changed, 24 insertions(+), 7 deletions(-)

You can find the missing includes in the attached patch

Kind regards,
Sven

[-- Attachment #1.3: 0002-missing-includes-1.patch --]
[-- Type: text/x-patch, Size: 601 bytes --]

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:26:24 +0200
Subject: [PATCH] missing includes 1
---
net/batman-adv/hard-interface.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index e0cd7ce..2dfbb84 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -36,6 +36,8 @@
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/workqueue.h>
+#include <net/net_namespace.h>
+#include <net/rtnetlink.h>

#include "bridge_loop_avoidance.h"
#include "debugfs.h"