Re: [B.A.T.M.A.N.] [PATCH 02/10] batman-adv: Suppress debugfs entries for netns's

Sven Eckelmann
2016-04-29T19:14:59Z

[-- Attachment #1.1: Type: text/plain, Size: 1608 bytes --]

=2D-nextPart2133075.52soJF7hlr
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday 28 April 2016 22:37:20 Andrew Lunn wrote:
> Debugfs is not netns aware. It thus has problems when the same
> interface name exists in multiple network name spaces.
>
> Work around this by not creating entries for interfaces in name spaces
> other than the default name space. This means meshes in network
> namespaces cannot be managed via debugfs, but there will soon be a
> netlink interface which is netns aware.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> net/batman-adv/debugfs.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)

You can find the missing includes in the attached patch

Kind regards,
Sven
=2D-nextPart2133075.52soJF7hlr
Content-Disposition: attachment; filename="0005-missing-includes-2.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0005-missing-includes-2.patch"

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:29:25 +0200
Subject: [PATCH] missing includes 2
=2D--
net/batman-adv/debugfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c
index 4a43ee1..e54f0da 100644
=2D-- a/net/batman-adv/debugfs.c
+++ b/net/batman-adv/debugfs.c
@@ -42,6 +42,7 @@
#include <linux/types.h>
#include <linux/uaccess.h>
#include <linux/wait.h>
+#include <net/net_namespace.h>
#include <stdarg.h>

#include "bridge_loop_avoidance.h"

=2D-nextPart2133075.52soJF7hlr--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 665 bytes --]

On Thursday 28 April 2016 22:37:20 Andrew Lunn wrote:
> Debugfs is not netns aware. It thus has problems when the same
> interface name exists in multiple network name spaces.
>
> Work around this by not creating entries for interfaces in name spaces
> other than the default name space. This means meshes in network
> namespaces cannot be managed via debugfs, but there will soon be a
> netlink interface which is netns aware.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> net/batman-adv/debugfs.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)

You can find the missing includes in the attached patch

Kind regards,
Sven

[-- Attachment #1.3: 0005-missing-includes-2.patch --]
[-- Type: text/x-patch, Size: 530 bytes --]

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:29:25 +0200
Subject: [PATCH] missing includes 2
---
net/batman-adv/debugfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/batman-adv/debugfs.c b/net/batman-adv/debugfs.c
index 4a43ee1..e54f0da 100644
--- a/net/batman-adv/debugfs.c
+++ b/net/batman-adv/debugfs.c
@@ -42,6 +42,7 @@
#include <linux/types.h>
#include <linux/uaccess.h>
#include <linux/wait.h>
+#include <net/net_namespace.h>
#include <stdarg.h>

#include "bridge_loop_avoidance.h"