Re: [B.A.T.M.A.N.] [PATCH 05/10] batman-adv: netlink: add originator and neighbor table queries

Sven Eckelmann
2016-04-29T19:15:10Z

[-- Attachment #1.1: Type: text/plain, Size: 2690 bytes --]

=2D-nextPart1642747.pOJncRhBeP
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Thursday 28 April 2016 22:37:23 Andrew Lunn wrote:
> From: Matthias Schiffer <mschiffer@universe-factory.net>
>
> Add BATADV_CMD_GET_ORIGINATORS and BATADV_CMD_GET_NEIGHBORS commands,
> using handlers bat_orig_dump and bat_neigh_dump in batadv_algo_ops. Will
> always return -EOPNOTSUPP for now, as no implementations exist yet.
>
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
> include/uapi/linux/batman_adv.h | 2 +
> net/batman-adv/netlink.c | 13 ++++
> net/batman-adv/originator.c | 142
> ++++++++++++++++++++++++++++++++++++++++ net/batman-adv/originator.h |
> 2 +
> net/batman-adv/types.h | 7 ++
> 5 files changed, 166 insertions(+)

You can find the missing includes in the attached patch

Kind regards,
Sven
=2D-nextPart1642747.pOJncRhBeP
Content-Disposition: attachment; filename="0011-missing-includes-5.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8"; name="0011-missing-includes-5.patch"

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:51:44 +0200
Subject: [PATCH] missing includes 5
=2D--
net/batman-adv/netlink.c | 1 +
net/batman-adv/originator.c | 2 ++
net/batman-adv/originator.h | 2 ++
3 files changed, 5 insertions(+)

diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 1d7dc27..a01bdf5 100644
=2D-- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -33,6 +33,7 @@
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

+#include "originator.h"
#include "hard-interface.h"
#include "soft-interface.h"
#include "translation-table.h"
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 3e053e1..d2ccbf3 100644
=2D-- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -28,8 +28,10 @@
#include <linux/list.h>
#include <linux/lockdep.h>
#include <linux/netdevice.h>
+#include <linux/netlink.h>
#include <linux/rculist.h>
#include <linux/seq_file.h>
+#include <linux/skbuff.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/workqueue.h>
diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h
index a8eb520..5c932d5 100644
=2D-- a/net/batman-adv/originator.h
+++ b/net/batman-adv/originator.h
@@ -31,7 +31,9 @@

#include "hash.h"

+struct netlink_callback;
struct seq_file;
+struct sk_buff;

bool batadv_compare_orig(const struct hlist_node *node, const void *data2);
int batadv_originator_init(struct batadv_priv *bat_priv);

=2D-nextPart1642747.pOJncRhBeP--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 784 bytes --]

On Thursday 28 April 2016 22:37:23 Andrew Lunn wrote:
> From: Matthias Schiffer <mschiffer@universe-factory.net>
>
> Add BATADV_CMD_GET_ORIGINATORS and BATADV_CMD_GET_NEIGHBORS commands,
> using handlers bat_orig_dump and bat_neigh_dump in batadv_algo_ops. Will
> always return -EOPNOTSUPP for now, as no implementations exist yet.
>
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
> include/uapi/linux/batman_adv.h | 2 +
> net/batman-adv/netlink.c | 13 ++++
> net/batman-adv/originator.c | 142
> ++++++++++++++++++++++++++++++++++++++++ net/batman-adv/originator.h |
> 2 +
> net/batman-adv/types.h | 7 ++
> 5 files changed, 166 insertions(+)

You can find the missing includes in the attached patch

Kind regards,
Sven

[-- Attachment #1.3: 0011-missing-includes-5.patch --]
[-- Type: text/x-patch, Size: 1489 bytes --]

From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 29 Apr 2016 20:51:44 +0200
Subject: [PATCH] missing includes 5
---
net/batman-adv/netlink.c | 1 +
net/batman-adv/originator.c | 2 ++
net/batman-adv/originator.h | 2 ++
3 files changed, 5 insertions(+)

diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 1d7dc27..a01bdf5 100644
--- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -33,6 +33,7 @@
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>

+#include "originator.h"
#include "hard-interface.h"
#include "soft-interface.h"
#include "translation-table.h"
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 3e053e1..d2ccbf3 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -28,8 +28,10 @@
#include <linux/list.h>
#include <linux/lockdep.h>
#include <linux/netdevice.h>
+#include <linux/netlink.h>
#include <linux/rculist.h>
#include <linux/seq_file.h>
+#include <linux/skbuff.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/workqueue.h>
diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h
index a8eb520..5c932d5 100644
--- a/net/batman-adv/originator.h
+++ b/net/batman-adv/originator.h
@@ -31,7 +31,9 @@

#include "hash.h"

+struct netlink_callback;
struct seq_file;
+struct sk_buff;

bool batadv_compare_orig(const struct hlist_node *node, const void *data2);
int batadv_originator_init(struct batadv_priv *bat_priv);