From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH v5 1/4] batman-adv: make the GW selection class algorithm specific
Date: Mon, 13 Jun 2016 12:45:17 +0200 [thread overview]
Message-ID: <3526113.DGLM0pS6Vy@bentobox> (raw)
In-Reply-To: <20160612041426.26339-2-a@unstable.cc>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
On Sunday 12 June 2016 12:14:23 Antonio Quartulli wrote:
[...]
> + if (bat_priv->algo_ops->gw.show_sel_class)
> + return bat_priv->algo_ops->gw.show_sel_class(bat_priv, buff);
[...]
> + if (bat_priv->algo_ops->gw.store_sel_class)
> + return bat_priv->algo_ops->gw.store_sel_class(bat_priv, buff,
> + count);
[...]
> /**
> + * struct batadv_algo_gw_ops - mesh algorithm callbacks (GW specific)
> + * @store_sel_class: parse and stores a new GW selection class
> + * @show_sel_class: prints the current GW selection class
> + */
> +struct batadv_algo_gw_ops {
> + ssize_t (*store_sel_class)(struct batadv_priv *bat_priv, char *buff,
> + size_t count);
> + ssize_t (*show_sel_class)(struct batadv_priv *bat_priv, char *buff);
> +};
Looks like these two are also optional. Can someone please add the "(optional)"
string to the kernel-doc like it was done in the initial batadv_algo_ops
patches? Thanks
Same for get_best_gw_node, is_eligible and print in patch 2
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-13 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-12 4:14 [B.A.T.M.A.N.] [PATCH v5 0/6] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support Antonio Quartulli
2016-06-12 4:14 ` [B.A.T.M.A.N.] [PATCH v5 1/4] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-06-13 10:45 ` Sven Eckelmann [this message]
2016-06-13 16:02 ` Antonio Quartulli
2016-06-12 4:14 ` [B.A.T.M.A.N.] [PATCH v5 2/4] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-06-13 11:45 ` Sven Eckelmann
2016-06-12 4:14 ` [B.A.T.M.A.N.] [PATCH v5 3/4] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-06-13 11:12 ` Sven Eckelmann
2016-06-13 16:02 ` Antonio Quartulli
2016-06-27 2:41 ` Antonio Quartulli
2016-06-13 11:26 ` Sven Eckelmann
2016-06-27 2:36 ` Antonio Quartulli
2016-06-27 6:19 ` Sven Eckelmann
2016-06-27 6:19 ` Antonio Quartulli
2016-06-13 11:45 ` Sven Eckelmann
2016-06-12 4:14 ` [B.A.T.M.A.N.] [PATCH v5 4/4] batman-adv: disable sysfs knobs when GW-mode is not implemented Antonio Quartulli
2016-06-13 10:47 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3526113.DGLM0pS6Vy@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox