From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 next 3/4] batman-adv: fix size of batadv_icmp_header
Date: Sat, 14 Dec 2013 17:39:21 +0800 [thread overview]
Message-ID: <3543660.ogTEPaiZir@diderot> (raw)
In-Reply-To: <1386253980-2415-1-git-send-email-antonio@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Thursday 05 December 2013 15:33:00 Antonio Quartulli wrote:
> struct batadv_icmp_header currently has a size of 17, which
> will be padded to 20 on some architectures. Fix this by
> unrolling the header into the parent structures.
>
> Moreover keep the ICMP parsing functions as generic as they
> are now by using a stub icmp_header struct during packet
> parsing.
>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
> ---
>
> Changes from v2:
> - readded comment next to msg_type memeber
>
>
>
> main.c | 4 ++--
> packet.h | 40 +++++++++++++++++++++++++++++++++++-----
> routing.c | 14 +++++++-------
> 3 files changed, 44 insertions(+), 14 deletions(-)
Applied in revision 6d80786.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2013-12-14 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 14:33 [B.A.T.M.A.N.] [PATCHv3 next 3/4] batman-adv: fix size of batadv_icmp_header Antonio Quartulli
2013-12-14 9:39 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3543660.ogTEPaiZir@diderot \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox