From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Add lower layer needed_(head|tail)room to own ones
Date: Sat, 08 Aug 2015 03:06:18 +0800 [thread overview]
Message-ID: <3592510.EADgsIozEl@voltaire> (raw)
In-Reply-To: <1438968522-3470-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On Friday, August 07, 2015 19:28:42 Sven Eckelmann wrote:
> The maximum of hard_header_len and maximum of all needed_(head|tail)room of
> all slave interfaces of a batman-adv device must be used to define the
> batman-adv device needed_(head|tail)room. This is required to avoid too
> small buffer problems when these slave devices try to send the encapsulated
> packet in a tx path without the possibility to resize the skbuff.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v4:
> - only check non-BATADV_IF_NOT_IN_USE interfaces
> - drop the batadv_hardif_disable_interface changes which are already
> handled by the non-BATADV_IF_NOT_IN_USE check
> v3:
> - set hard_header_len always to ETH_HLEN and only modify needed_headroom
> as done in mac80211/vxlan
> - do the same for needed_tailroom
> v2:
> - based on patch "batman-adv: don't access unregistered net_device object"
> - remove the function call from batadv_update_min_mtu
> - instead use batadv_hardif_disable_interface +
> batadv_hardif_enable_interface
> ---
> net/batman-adv/hard-interface.c | 41
> +++++++++++++++++++++++++++++++++++++++++ net/batman-adv/soft-interface.c
> | 2 --
> 2 files changed, 41 insertions(+), 2 deletions(-)
Applied in revision e2b4301.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-08-07 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 17:28 [B.A.T.M.A.N.] [PATCH v4] batman-adv: Add lower layer needed_(head|tail)room to own ones Sven Eckelmann
2015-08-07 19:06 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3592510.EADgsIozEl@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox