From: Marek Lindner <mareklindner@neomailbox.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies
Date: Sat, 01 Jul 2017 23:34:37 +0800 [thread overview]
Message-ID: <3606832.Ug1eaxX1Ot@lafayette> (raw)
In-Reply-To: <20170623154826.7792-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Friday, June 23, 2017 5:48:26 PM HKT Linus Lüssing wrote:
> @@ -1946,6 +1977,7 @@ batadv_tt_global_dump_subentry(struct sk_buff *msg,
> u32 portid, u32 seq, struct batadv_tt_orig_list_entry *orig, bool best)
> {
> + u16 flags = (common->flags & (~BATADV_TT_SYNC_MASK)) | orig->flags;
Why do we need to output the combined global (partially masked) and the flags
propagated by originator ? Shouldn't writing orig->flags be what we want ?
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-07-01 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 15:48 [B.A.T.M.A.N.] [PATCH maint] batman-adv: fix TT sync flag inconsistencies Linus Lüssing
2017-06-23 15:56 ` Linus Lüssing
2017-06-26 1:30 ` Linus Lüssing
2017-07-01 15:34 ` Marek Lindner [this message]
2017-07-01 16:47 ` Linus Lüssing
2017-07-03 3:58 ` Marek Lindner
2017-07-01 17:34 ` Linus Lüssing
2017-07-03 4:08 ` Antonio Quartulli
2017-07-05 5:59 ` Linus Lüssing
2017-07-06 5:05 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3606832.Ug1eaxX1Ot@lafayette \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox