On Thursday 30 January 2014 00:15:10 Antonio Quartulli wrote: > On 30/01/14 00:12, Antonio Quartulli wrote: > > pskb_may_pull() returns 1 on success and 0 in case of failure, > > therefore checking for the return value being negative does > > not make sense at all. > > > > > > I should have added: > > This way if the function fails we will probably read beyond the current > skb data buffer. Applied in revision eabdc31. Thanks, Marek