Re: [B.A.T.M.A.N.] [PATCH] batctl: add option for multiif orig table

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

On Tuesday 18 February 2014 15:13:24 Simon Wunderlich wrote:
> @@ -162,7 +175,10 @@ int handle_debug_table(char *mesh_iface, int
> debug_table, int argc, char **argv) return EXIT_FAILURE;
>         }
>  
> -       debugfs_make_path(DEBUG_BATIF_PATH_FMT "/", mesh_iface, full_path,
> sizeof(full_path)); +       if (orig_iface)
> +               debugfs_make_path(DEBUG_BATIF_PATH_FMT "/", orig_iface,
> full_path, sizeof(full_path)); +       else
> +               debugfs_make_path(DEBUG_BATIF_PATH_FMT "/", mesh_iface,
> full_path, sizeof(full_path)); return read_file(full_path, (char
> *)batctl_debug_tables[debug_table].debugfs_name, read_opt, orig_timeout,
> watch_interval,
>                          batctl_debug_tables[debug_table].header_lines);

While playing with your patch I noticed a couple of things:

 * 'batctl originators -i eth0' is equivalent to 'batctl -m eth0 originators'
 * the latter works even without your patch
 * the orig table output does not say which interface we are looking at but 
always reports: (bat0 BATMAN_IV)
 * /sys/kernel/debug/batman_adv/ contains all sorts of hard-interfaces on my 
test setup even if they are not used by batman-adv - is the intended ?


Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]