From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv4] batman-adv: Introduce forward packet creation helper
Date: Mon, 20 Jun 2016 22:14:28 +0200 [thread overview]
Message-ID: <3881329.4jsIrYQ9vh@sven-edge> (raw)
In-Reply-To: <1466451595-6347-1-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Monday 20 June 2016 21:39:54 Linus Lüssing wrote:
> This patch abstracts the forward packet creation into the new function
> batadv_forw_packet_alloc().
>
> The queue counting and interface reference counters are now handled
> internally within batadv_forw_packet_alloc() and its
> batadv_forw_packet_free() counterpart. This should reduce the risk of
> having reference/queue counting bugs again and should increase
> code readibility.
>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> Changelog v4:
> * Removed goto in batadv_iv_ogm_aggregate_new()
> * Removed two goto's in batadv_forw_packet_alloc()
> * Easier to read debug output code in batadv_forw_packet_alloc()
> * Renamed "out" and "packet_free" jump labels in batadv_add_bcast_packet_to_list()
> to "err" and "err_packet_free"
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-20 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 19:39 [B.A.T.M.A.N.] [PATCHv4] batman-adv: Introduce forward packet creation helper Linus Lüssing
2016-06-20 20:14 ` Sven Eckelmann [this message]
2016-07-07 6:20 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3881329.4jsIrYQ9vh@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox