From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: output errors to stderr
Date: Wed, 05 Dec 2012 09:23:18 +0100 [thread overview]
Message-ID: <3906319.Tukpzm2960@bentobox> (raw)
In-Reply-To: <50BE9250.2050303@web.de>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Wednesday 05 December 2012 01:16:16 Moritz Warning wrote:
> batctl outputs many errors to stdout instead of stderr.
> This patch corrects this behavior by redirecting errors
> and the usage texts to stderr.
>
> Signed-off-by: Moritz Warning <moritzwarning at web.de>
Your mail address looks wrong.
> - if (strcmp(argv[1], "-h") == 0)
> - goto err;
> + if (strcmp(argv[1], "-h") == 0) {
> + print_usage();
> + exit(EXIT_SUCCESS);
> + }
>
This seems to be unrelated. Please remove it from the patch.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-05 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 0:16 [B.A.T.M.A.N.] [PATCH] batctl: output errors to stderr Moritz Warning
2012-12-05 0:25 ` Moritz Warning
2012-12-05 8:23 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3906319.Tukpzm2960@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox