On Tuesday, June 28, 2016 04:14:41 Linus Lüssing wrote: > On Mon, Jun 27, 2016 at 08:15:42AM +0200, Sven Eckelmann wrote: > > The function batadv_send_skb_unicast is not acquiring a reference for an > > orig_node nor removing it from any datastructure. It still reduces the > > reference counter for an object which is still in the hands of the caller. > > > > This is confusing and can lead in the future to problems in the reference > > handling of the caller function. > > > > Signed-off-by: Sven Eckelmann > > --- > > > > v3: > > - adjust commit message to sound less like an fix (thanks Linus) > > - Remove " and release a reference to this orig_node" from kerneldoc of > > batadv_send_skb_unicast (thanks Linus) > > > > v2: > > - remove bogus multicast example > > > > - remove Fixes: > > --- > > Acked-by: Linus Lüssing Applied in revision d7d5613. Thanks, Marek