Re: [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix transmission of final, 16th fragment

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

On Montag, 13. Februar 2017 20:44:31 CET Linus Lüssing wrote:
> Trying to split and transmit a unicast packet in 16 parts will fail for
> the final fragment: After having sent the 15th one with a frag_packet.no
> index of 14, we will increase the the index to 15 - and return with an
> error code immediately, even though one more fragment is due for
> transmission and allowed.
> 
> Fixing this issue by moving the check before incrementing the index.
> 
> While at it, adding an unlikely(), because the check is actually more of
> an assertion.
> 
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> 
> ---
> 
> Compile time tested only

Seems to make sense. But have to talk with Simon how he wants to proceed
with the maint branch regarding the net.git submissions. And we should
add The fixes line before committing.

Fixes: db56e4ecf5c2 ("batman-adv: Fragment and send skbs larger than mtu")
Reviewed-by: Sven Eckelmann <sven@narfation.org>

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]