From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Simon Wunderlich <simon@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: fix rcu pointer comparison problem
Date: Tue, 26 Nov 2013 01:51:13 +0800 [thread overview]
Message-ID: <4090496.CKZxZ93Xi7@diderot> (raw)
In-Reply-To: <1385298345-13746-3-git-send-email-sw@simonwunderlich.de>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Sunday 24 November 2013 14:05:45 Simon Wunderlich wrote:
> From: Simon Wunderlich <simon@open-mesh.com>
>
> sparse complained about:
>
> routing.c:482:64: error: incompatible types in comparison expression
> (different address spaces)
>
> This was due to comparing a __rcu pointer with a regular one. Fix that
> by adding the missing rcu_dereference call. A temporary variable is used
> to comply with the line length limit, use the opportunity to beautify a
> few other places.
>
> This problem was introduced in commit
> 797edd9e87ac838711e03498a4ae795b600191af ("batman-adv: add bonding
> again")
>
> Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
> ---
> routing.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
Applied in revision f2a1300.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-11-25 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 13:05 [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: fix another sparse warning in batadv_iv_ogm_emit Simon Wunderlich
2013-11-24 13:05 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: fix wrong alignment for batadv_originators_hardif_open Simon Wunderlich
2013-11-25 17:49 ` Marek Lindner
2013-11-24 13:05 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: fix rcu pointer comparison problem Simon Wunderlich
2013-11-25 17:51 ` Marek Lindner [this message]
2013-11-25 17:48 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: fix another sparse warning in batadv_iv_ogm_emit Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4090496.CKZxZ93Xi7@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=simon@open-mesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox