Re: [B.A.T.M.A.N.] [PATCH v3] batman-adv: iv_ogm, Reduce code duplication

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

On Sunday, July 03, 2016 11:07:14 Sven Eckelmann wrote:
> From: Markus Pargmann <mpa@pengutronix.de>
> 
> The difference between tq1 and tq2 are calculated the same way in two
> separate functions.
> 
> This patch moves the common code to a seperate function
> 'batadv_iv_ogm_neigh_diff' which handles everything necessary. The other
> two functions can then handle errors and use the difference directly.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> [sven@narfation.org: rebased on current version, initialize return variable
> in batadv_iv_ogm_neigh_diff, add kerneldoc, convert to bool return type]
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v3:
>  - rebased on current version
>  - initialize return variable in batadv_iv_ogm_neigh_diff
>  - add kerneldoc for batadv_iv_ogm_neigh_diff
>  - convert batadv_iv_ogm_neigh_diff to bool return type
> ---
>  net/batman-adv/bat_iv_ogm.c | 77
> +++++++++++++++++++++++++++------------------ 1 file changed, 47
> insertions(+), 30 deletions(-)

Applied in revision b7232de.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]