From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Prevent duplicated softif_vlan entry
Date: Thu, 06 Sep 2018 20:00:35 +0800 [thread overview]
Message-ID: <41525005.Pqo06DrDOh@rousseau> (raw)
In-Reply-To: <20180812190445.28013-4-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Monday, 13 August 2018 03:04:43 HKT Sven Eckelmann wrote:
> + /* adding sysfs can fail but it is now to late to handle it.
> + * it can also not be in the spinlock section due to the sleeping
> + * behavior of the sysfs functions and the fs_reclaim lock
> + */
> + batadv_sysfs_add_vlan(bat_priv->soft_iface, vlan);
> +
> /* add a new TT local entry. This one will be marked with the
> NOPURGE * flag
> */
Why is it too late to handle the error ? As long as this function returns
an error to the caller the kernel will destroy the interface, ultimately
allowing batman to free anything related to this interface ?
Having debugged some nasty TT VLAN bugs which were due to missing
error handling in the VLAN creation routine make me a little nervous
about the proposed approach ...
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-06 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-12 19:04 [B.A.T.M.A.N.] [PATCH 0/5] batman-adv: Missing list checks for *list_add* Sven Eckelmann
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Prevent duplicated gateway_node entry Sven Eckelmann
2018-09-06 11:41 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Prevent duplicated nc_node entry Sven Eckelmann
2018-09-06 11:45 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Prevent duplicated softif_vlan entry Sven Eckelmann
2018-09-06 12:00 ` Marek Lindner [this message]
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Prevent duplicated global TT entry Sven Eckelmann
2018-09-06 12:03 ` Marek Lindner
2018-08-12 19:04 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Prevent duplicated tvlv handler Sven Eckelmann
2018-09-06 12:05 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41525005.Pqo06DrDOh@rousseau \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox