[B.A.T.M.A.N.] [PATCH 0/7] alfred: Allow out-of-order TXEND

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]

Hi,

alfred allows to have out-of-order push data packet delivery. But these push
data packets are only accepted when they finish with an TXEND that has as its
seqno the amount of packets alfred received for this transaction. A TXEND
packet which is received before the last push data frame was received would
therefore cause the complete transaction to be canceled on the receiver side.

It was observed on a TP-Link TL-WR841N/ND v8 [1] that after the upgrade to
Gluon 2016.2 many (if not the most) transaction were out of order. The TXEND
was received before the actual push data was submitted. The master server
reacted to this by:

1. TXEND packet received to unknown transaction with seqno != 0
   -> TXEND packet was dropped
2. PUSH_DATA packet received with seqno 0 received
   -> new transaction was created
3. transaction timeout happened
   -> transaction was dropped

This patchset now changes the behavior to automatically create transactions
when TXEND packets are received. The routines to decode TXEND and PUSH_DATA
packets will check if all frames of a transaction were received and commit the
data when the check was successful.

This stabilized the statistics [2] for the previously mentioned node.

Kind regards,
	Sven

[1] https://stats.freifunk-vogtland.net/dashboard/db/node?var-node=10feedb73eb2&from=1478782587039&to=1478902771655
[2] https://stats.freifunk-vogtland.net/dashboard/db/node?var-node=10feedb73eb2&from=1478902641027&to=1478938850519

Sven Eckelmann (7):
  alfred: Avoid hash search for transaction cleanup
  alfred: Move tx finish functionality in extra function
  alfred: Remove checks for committed/dropped transaction
  alfred: Don't force cleanup of transaction on TXEND
  alfred: Use expected packet count to finished transactions
  alfred: Allow PUSH_DATA to finish transactions
  alfred: Allow TXEND to start new transaction

 alfred.h    | 11 +++++---
 recv.c      | 84 +++++++++++++++++++++++++++++++------------------------------
 unix_sock.c |  2 +-
 3 files changed, 51 insertions(+), 46 deletions(-)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]