Re: [B.A.T.M.A.N.] [PATCH v3 2/2] batman-adv: Simple (re)broadcast avoidance

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 2555 bytes --]

On Samstag, 6. August 2016 04:06:21 CEST Linus Lüssing wrote:
[...]
> diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
> index 08ce361..56529b3 100644
> --- a/net/batman-adv/hard-interface.c
> +++ b/net/batman-adv/hard-interface.c
> @@ -228,6 +228,58 @@ bool batadv_is_wifi_netdev(struct net_device *net_device)
>  	return false;
>  }
>  
> +/**
> + * batadv_hardif_no_broadcast - check whether (re)broadcast is necessary
> + * @if_outgoing:

I think you forgot to add text here

[...]
> diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
> index 5f3bfc4..890d07d 100644
> --- a/net/batman-adv/originator.c
> +++ b/net/batman-adv/originator.c
> @@ -517,7 +517,8 @@ batadv_neigh_node_get(const struct batadv_orig_node *orig_node,
>   */
>  static struct batadv_hardif_neigh_node *
>  batadv_hardif_neigh_create(struct batadv_hard_iface *hard_iface,
> -			   const u8 *neigh_addr)
> +			   const u8 *neigh_addr,
> +			   struct batadv_orig_node *orig_node)

orig_node seems to be missing from kernel-doc

[...]
> @@ -561,7 +563,8 @@ out:
>   */
>  static struct batadv_hardif_neigh_node *
>  batadv_hardif_neigh_get_or_create(struct batadv_hard_iface *hard_iface,
> -				  const u8 *neigh_addr)
> +				  const u8 *neigh_addr,
> +				  struct batadv_orig_node *orig_node)

orig_node seems to be missing from kernel-doc

[...]
> diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
> index 610f2c4..c1e5aa7 100644
> --- a/net/batman-adv/routing.c
> +++ b/net/batman-adv/routing.c
> @@ -1142,6 +1142,7 @@ int batadv_recv_bcast_packet(struct sk_buff *skb,
>  		goto out;
>  
>  	batadv_skb_set_priority(skb, sizeof(struct batadv_bcast_packet));
> +	skb_set_inner_mac_header(skb, sizeof(struct batadv_bcast_packet));

skb_set_inner_mac_header doesn't seem to be defined in 3.9 (first defined in 
aefbd2b3c2a9c657605e4337f9919d6c6273e8e6). Any idea how to fix build/
functionality for these kernels?

[...]
> @@ -634,6 +641,51 @@ static void batadv_send_outstanding_bcast_packet(struct work_struct *work)
>  		if (forw_packet->num_packets >= hard_iface->num_bcasts)
>  			continue;
>  
> +		/* hint for own origin -> no neigh_node */
> +		if (skb_mac_header(forw_packet->skb) ==
> +		    skb_inner_mac_header(forw_packet->skb)) {

skb_inner_mac_header doesn't seem to be defined in 3.9 (first defined in 
aefbd2b3c2a9c657605e4337f9919d6c6273e8e6). Any idea how to fix build/
functionality for these kernels?


Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]