From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [RFC v4] throughput meter on steroids^W netlink
Date: Wed, 04 May 2016 21:02:05 +0200 [thread overview]
Message-ID: <4642303.DsCp7UQf8m@bentobox> (raw)
[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]
Hi,
I was asked by the batman-adv maintainers to port the tp_meter to netlink. And
I shouldn't do it with the patches from Andrew/Matthias applied but with only
a small part of patch 4.
I know, this isn't the nicest move but it allowed me to restructure the first
commit a little bit. I've extracted the part which introduced the netlink
family + a restructured batman_adv.h. I've also added the part which
introduces the generic mesh information as extra patch (+kerneldoc). This
added some attributes which I need in tp_meter. But I can also remove the
patch and only merge the necessary parts.
@Andrew, I hope you don't take it the wrong way. I really like your work and
even borrowed parts of the code for the tp_meter interface. So you are now
allowed to criticize the hell out of the changes and request some free beer
from Antonio, Marek and Simon :). But I hope that you like the adjustments to
the initial parts (at least a little bit). You would have to rebase your
changes (which I still want to get integrated) on top when these things here
are merged. I would also be willing to do the rebase myself and send you the
result (so you can add the kerneldoc and maybe make further adjustments).
The only "big" conflicts I see are related to the order of attributes. But
this was a long day for me and I may have forgotten something.
@the_rest: Do you find the bugs introduced by moving it to netlink?
The one which I know about is the inability to receive signals while the
kernel is doing the wait_event (So the BATADV_CMD_TP_METER_CANCEL doesn't work
at all). I am waiting for recommendations. The one which
comes to my mind is not to wait for the thing to finish but to just return
immediately. The client would then have to some kind of event listener enabled
which waits until the thing finished. This approach would also require some
kind of session info exchange. Does anyone else have a good idea?
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next reply other threads:[~2016-05-04 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 19:02 Sven Eckelmann [this message]
2016-05-04 19:06 ` [B.A.T.M.A.N.] [PATCH v4 1/5] batman-adv: Add stripped down version of MAINTAINERS file Sven Eckelmann
2016-05-04 19:06 ` [B.A.T.M.A.N.] [PATCH v4 2/5] batman-adv: add generic netlink family for batman-adv Sven Eckelmann
2016-05-04 19:06 ` [B.A.T.M.A.N.] [PATCH v4 3/5] batman-adv: add netlink command to query generic mesh information files Sven Eckelmann
2016-05-04 19:06 ` [B.A.T.M.A.N.] [PATCH v4 4/5] batman-adv: return netdev status in the TX path Sven Eckelmann
2016-05-04 19:06 ` [B.A.T.M.A.N.] [PATCH v4 5/5] batman-adv: throughput meter implementation Sven Eckelmann
2016-05-04 19:07 ` [B.A.T.M.A.N.] [PATCH v4 1/4] batctl: Split list of objects in Makefile into separate lines Sven Eckelmann
2016-05-04 19:07 ` [B.A.T.M.A.N.] [PATCH v4 2/4] batctl: Add basic infrastructure to integrate netlink Sven Eckelmann
2016-05-04 19:07 ` [B.A.T.M.A.N.] [PATCH v4 3/4] batctl: Add attributes/command for BATADV_CMD_GET_MESH_INFO Sven Eckelmann
2016-05-04 19:07 ` [B.A.T.M.A.N.] [PATCH v4 4/4] batctl: introduce throughput meter support Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4642303.DsCp7UQf8m@bentobox \
--to=sven.eckelmann@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox