From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org,
Remi Pommarel <repk@triplefau.lt>,
Antonio Quartulli <a@unstable.cc>
Cc: Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>
Subject: Re: [PATCH v2 5/5] batman-adv: Don't keep redundant TT change events
Date: Sun, 17 Nov 2024 09:25:42 +0100 [thread overview]
Message-ID: <4709754.CvnuH1ECHv@sven-l14> (raw)
In-Reply-To: <1c8b34d63121834bdf6d39c7ed1447ae3536be7d.1731792497.git.repk@triplefau.lt>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Saturday, 16 November 2024 22:32:09 CET Remi Pommarel wrote:
> --- a/net/batman-adv/translation-table.c
> +++ b/net/batman-adv/translation-table.c
> @@ -500,14 +500,17 @@ static void batadv_tt_local_event(struct batadv_priv *bat_priv,
> /* this is a second add in the same originator interval. It
> * means that flags have been changed: update them!
> */
> - if (!del_op_requested && !del_op_entry)
> + if (del_op_requested == del_op_entry) {
> entry->change.flags = flags;
> + goto discard;
> + }
The comment is no longer in sync with the actual code. It is now also about
DEL's and and only about ADDs.
And I am not sure about the flags update on DELs - maybe Antonio can enlighten
us here.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-11-17 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 21:32 [PATCH v2 0/5] batman-adv: TT change events fixes and improvements Remi Pommarel
2024-11-16 21:32 ` [PATCH v2 1/5] batman-adv: Do not send uninitialized TT changes Remi Pommarel
2024-11-16 21:32 ` [PATCH v2 2/5] batman-adv: Remove uninitialized data in full table TT response Remi Pommarel
2024-11-16 21:32 ` [PATCH v2 3/5] batman-adv: Do not let TT changes list grows indefinitely Remi Pommarel
2024-11-16 21:32 ` [PATCH v2 4/5] batman-adv: Remove atomic usage for tt.local_changes Remi Pommarel
2024-11-16 21:32 ` [PATCH v2 5/5] batman-adv: Don't keep redundant TT change events Remi Pommarel
2024-11-17 8:25 ` Sven Eckelmann [this message]
2024-11-17 8:24 ` [PATCH v2 0/5] batman-adv: TT change events fixes and improvements Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4709754.CvnuH1ECHv@sven-l14 \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=mareklindner@neomailbox.ch \
--cc=repk@triplefau.lt \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox