From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: add multicast flags netlink support
Date: Sun, 04 Mar 2018 14:36:40 +0100 [thread overview]
Message-ID: <4734050.hZAXbvf8iE@sven-edge> (raw)
In-Reply-To: <20180227081016.13122-2-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
On Dienstag, 27. Februar 2018 09:10:16 CET Linus Lüssing wrote:
> + if (nla_put_u8(msg, BATADV_ATTR_MCAST_FLAGS, flags) ||
> + nla_put_u8(msg, BATADV_ATTR_MCAST_FLAGS_PRIV, flags_priv))
> + return -EMSGSIZE;
Are you sure that 8 flags are enough for the future? Not that you are ending
up with a 9th flag and don't know where to put it.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-04 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 8:10 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add DAT cache netlink support Linus Lüssing
2018-02-27 8:10 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: add multicast flags " Linus Lüssing
2018-03-04 12:36 ` Sven Eckelmann
2018-03-04 13:36 ` Sven Eckelmann [this message]
2018-03-04 12:36 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: add DAT cache " Sven Eckelmann
2018-03-04 16:41 ` Sven Eckelmann
2018-03-04 17:34 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4734050.hZAXbvf8iE@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox