From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v9 2/2] batman-adv: throughput meter implementation
Date: Wed, 18 May 2016 09:50:21 +0200 [thread overview]
Message-ID: <487854669.Af666lYg74@bentobox> (raw)
In-Reply-To: <20160518021611.GG12056@prodigo.lan>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Wednesday 18 May 2016 10:16:11 Antonio Quartulli wrote:
[...]
> one very last question (sorry for not spotting this earlier): if we don't handle
> the TP meter with the icmp_socket anymore, why do we tight the TP initialization
> to the socket initialization ?
>
> Is there any reason to have it here ? Or we should move the
> batadv_tp_meter_init() call to somewhere else ?
It was basically just because it is still bound to the ICMP stuff (even when
it is not using the socket itself). But when thinking about it, then you are
right. This should be moved to the global initialization. Not all ICMP
handling is done in icmp_socket.c and thus this also doesn't have to be added
here. main.c (batadv_init) is a better place for it.
[...]
> > + * Return: 0 on success, <0 on error
>
> you forgot the space between < and 0 ;P but if the rest is ok, I am sure Marek
> could add it :)
Can I just say that it is an copy+paste error from your comment in
bat_v_ogm.c ;)
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-18 7:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 17:31 [B.A.T.M.A.N.] [PATCH v9 0/3] batman-adv: throughput meter Sven Eckelmann
2016-05-17 17:32 ` [B.A.T.M.A.N.] [PATCH v9 1/2] batman-adv: return netdev status in the TX path Sven Eckelmann
2016-05-17 17:32 ` [B.A.T.M.A.N.] [PATCH v9 2/2] batman-adv: throughput meter implementation Sven Eckelmann
2016-05-18 2:16 ` Antonio Quartulli
2016-05-18 7:50 ` Sven Eckelmann [this message]
2016-05-17 17:32 ` [B.A.T.M.A.N.] [PATCH v9] batctl: introduce throughput meter support Sven Eckelmann
2016-05-17 18:49 ` [B.A.T.M.A.N.] [PATCH v10] " Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487854669.Af666lYg74@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox