From: Alberto Escudero-Pascual <aep@it46.se>
To: Sven Eckelmann <sven@narfation.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [Patch] vis: Modified format of JSON output.
Date: Thu, 10 Mar 2011 08:55:36 +0100 [thread overview]
Message-ID: <4D7883F8.7060303@it46.se> (raw)
In-Reply-To: <201103091804.55424.sven@narfation.org>
Hi Sven,
Here you can get the two files
PATCHED VIS.C
http://dev.villagetelco.org/svn/villagetelco/server/trunk/src/install/vis/vis.c
and
http://dev.villagetelco.org/svn/villagetelco/server/trunk/src/install/vis/vis.c.patch
The patch was applied against the version
http://downloads.open-mesh.org/batman/releases/batman-0.3.2/vis-0.3.2.tar.gz
* The patch fixes three issues
- Reporting of duplicated entries in the VIS output, this is fixed in
trunk but not in vis.0.3.2
- Removed a gcc warning related to the use of chdir()
- Cleaned up the JSON output of vis
Our code is in SVN so I have not git-send-email magic :)
-aep
On 03/09/2011 06:04 PM, Sven Eckelmann wrote:
> On Wednesday 09 March 2011 17:48:32 elektra wrote:
>> The current vis server JSON output format is breaking the json_decode()
>> function for PHP.
>>
>> This patch mainly:
>> - Removes all spaces
>> - Removes all the \t TABS
>> - Double quotes the string-variables
>>
>> Reported-by: "Alberto Escudero-Pascual" <aep@it46.se>
>> Signed-off-by: "elektra" <onelektra@gmx.net>
>
> I am not sure if anyone currently maintains batmand and vis.
>
> Anyway, your patch is more or less scrambled. Can you please resend it using a
> client which doesn't create a wordwrap and space massacre[1]. Many people here
> seem to use git-send-email for that purpose.
>
> Kind regards,
> Sven
>
> [1] http://kernel.org/doc/Documentation/email-clients.txt
next prev parent reply other threads:[~2011-03-10 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 16:48 [B.A.T.M.A.N.] [Patch] vis: Modified format of JSON output elektra
2011-03-09 17:04 ` Sven Eckelmann
2011-03-10 7:55 ` Alberto Escudero-Pascual [this message]
2011-03-10 8:28 ` Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2011-03-09 17:16 elektra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7883F8.7060303@it46.se \
--to=aep@it46.se \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox