Re: [B.A.T.M.A.N.] Unused structs in Catwoman packet buffers

Martin Hundebøll
2011-10-17T17:34:32Z

Hi Antonio,

On 2011-10-17 18:37, Antonio Quartulli wrote:
> Hello Martin,
>
> and thank you for the explanation.
>
> On Mon, Oct 17, 2011 at 03:16:25 +0200, Martin Hundebøll wrote:
>> Now here's the question:
>> When a list of a certain coding_path becomes empty, should I free the coding_path right away, or should I timestamp it and mark it for removal at a later time. The thing is that I don't know whether a new packet for the same coding_path will arrive in a short moment. If I have just freed the coding_path struct, I would have to spend ressources to initialize it again...
>>
>> It is probably a micro-optimiziation and the simplest solution would be to just free it right away, but I would like to have your comments anyways.
>
> In my opinion it would be better to _keep_ the struct even if the corresponding
> packet list is empty.

I agree. I have just made a housekeeping task to clean up other elements, so it shouldn't be a problem to add the coding_path here :)

Thanks!

--
Kind regards
Martin Hundebøll

+45 61 65 54 61
martin@hundeboll.net

Nordborggade 57, 2. tv
8000 Aarhus C
Denmark