From: "Martin Hundebøll" <martin@hundeboll.net>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Rm trailing whitespace from is_my_mac() in main.c
Date: Sat, 03 Dec 2011 16:39:30 +0100 [thread overview]
Message-ID: <4EDA42B2.8070104@hundeboll.net> (raw)
In-Reply-To: <201112031527.51151.lindner_marek@yahoo.de>
On 2011-12-03 08:27, Marek Lindner wrote:
> I don't have a trailing whitespace space there and you are removing an entire
> (empty) line. Not just a whitespace ?
Yes, sorry. The commit should say "empty line" instead of "whitespace". The empty line is also present on git.open-mesh.org:
http://git.open-mesh.org/?p=batman-adv.git;a=blob;f=main.c;h=fb87bdc2ce9bdba9b551f90fcdcada42fdc594a4;hb=refs/heads/master#l173
> My checkpatch also does not complain about your first patch. Where did you get
> your checkpatch from ?
Downloaded it from git.kernel.org:
http://git.kernel.org/?p=linux/kernel/git/apw/checkpatch.git;a=blob;f=scripts/checkpatch.pl;h=e29eeea86388d88d7c878383186318632ddac6eb;hb=HEAD
Also tried to download the file from 3.1-tagged tree, which make the same complaints as I mentioned on IRC:
Patch: http://dpaste.com/664910/
checkpatch.pl complaints: http://paste.pocoo.org/show/515753/
I will make a patch v2 with a corrected commit message.
--
Kind regards
Martin Hundebøll
+45 61 65 54 61
martin@hundeboll.net
Nordborggade 57, 2. tv
8000 Aarhus C
Denmark
next prev parent reply other threads:[~2011-12-03 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 14:15 [B.A.T.M.A.N.] [PATCH] batman-adv: Move is_out_of_time() to main.c for general use Martin Hundebøll
2011-12-02 14:37 ` Martin Hundebøll
2011-12-03 7:36 ` Marek Lindner
2011-12-03 15:41 ` Martin Hundebøll
2011-12-03 15:46 ` Marek Lindner
2011-12-03 15:54 ` Martin Hundebøll
2011-12-08 12:32 ` [B.A.T.M.A.N.] [PATCHv2] batman-adv: Move is_out_of_time() to main.h " Martin Hundebøll
2011-12-10 9:28 ` Marek Lindner
2011-12-02 14:39 ` [B.A.T.M.A.N.] [PATCH] batman-adv: Rm trailing whitespace from is_my_mac() in main.c Martin Hundebøll
2011-12-03 7:27 ` Marek Lindner
2011-12-03 15:39 ` Martin Hundebøll [this message]
2011-12-08 11:48 ` [B.A.T.M.A.N.] [PATCHv2] batman-adv: Rm empty line " Martin Hundebøll
2011-12-10 9:18 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDA42B2.8070104@hundeboll.net \
--to=martin@hundeboll.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox