From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4EDA4621.905@hundeboll.net> Date: Sat, 03 Dec 2011 16:54:09 +0100 From: =?UTF-8?B?TWFydGluIEh1bmRlYsO4bGw=?= MIME-Version: 1.0 References: <1322835344-23077-1-git-send-email-martin@hundeboll.net> <201112031536.26477.lindner_marek@yahoo.de> <4EDA4332.6080706@hundeboll.net> <201112032346.52327.lindner_marek@yahoo.de> In-Reply-To: <201112032346.52327.lindner_marek@yahoo.de> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Move is_out_of_time() to main.c for general use Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org On 2011-12-03 16:46, Marek Lindner wrote: > On Saturday, December 03, 2011 23:41:38 Martin Hundebøll wrote: >> On 2011-12-03 08:36, Marek Lindner wrote: >>> Since it is a simple one-liner you could make it a define or at least >>> static inline (in main.h). >> >> Correct. Maybe the correct solution is to remove the function and just call >> time_is_before_jiffies() directly instead? > > Guess you misread me. I like the idea of having this easy to read wrapper. > Before you moved it to main.c it was a static function. The compiler could > better optimize it. OK. Didn't misread you; just tried to think :) I'll send a patch with moving it to an inline function in main.h. -- Kind regards Martin Hundebøll +45 61 65 54 61 martin@hundeboll.net Nordborggade 57, 2. tv 8000 Aarhus C Denmark