From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4F30EFDA.9010405@hundeboll.net> Date: Tue, 07 Feb 2012 10:33:14 +0100 From: =?UTF-8?B?TWFydGluIEh1bmRlYsO4bGw=?= MIME-Version: 1.0 References: <201202071719.22804.lindner_marek@yahoo.de> <1328606451-3418-1-git-send-email-lindner_marek@yahoo.de> <1328606451-3418-2-git-send-email-lindner_marek@yahoo.de> In-Reply-To: <1328606451-3418-2-git-send-email-lindner_marek@yahoo.de> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Subject: Re: [B.A.T.M.A.N.] [PATCH 3/8] batman-adv: randomize initial seqno to avoid collision Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org On 2012-02-07 10:20, Marek Lindner wrote: > Signed-off-by: Marek Lindner > --- > bat_iv_ogm.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/bat_iv_ogm.c b/bat_iv_ogm.c > index 3eff7f0..4ac2d1d 100644 > --- a/bat_iv_ogm.c > +++ b/bat_iv_ogm.c > @@ -33,6 +33,11 @@ > static void bat_iv_ogm_iface_enable(struct hard_iface *hard_iface) > { > struct batman_ogm_packet *batman_ogm_packet; > + unsigned long random_seqno; > + > + /* randomize initial seqno to avoid collision */ > + get_random_bytes(&random_seqno, sizeof(unsigned long)); > + atomic_set(&hard_iface->seqno, (uint32_t)random_seqno); Wouldn't it be better to cast "unsigned long" in the call to atomic_set()? -- Kind Regards, Martin Hundebøll Nordborggade 57, 2. 1 8000 Aarhus C +45 61 65 54 61 martin@hundeboll.net