From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4FF1574B.2040506@hundeboll.net> Date: Mon, 02 Jul 2012 10:09:47 +0200 From: =?UTF-8?B?TWFydGluIEh1bmRlYsO4bGw=?= MIME-Version: 1.0 References: <1341144314-20995-1-git-send-email-sven@narfation.org> In-Reply-To: <1341144314-20995-1-git-send-email-sven@narfation.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: Split batadv_priv in sub-structures for features Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking Hi Sven, On 07/01/2012 02:05 PM, Sven Eckelmann wrote: > The structure batadv_priv grows everytime a new feature is introduced. It gets > hard to find the parts of the struct that belongs to a specific feature. This > becomes even harder by the fact that not every feature uses a prefix in the > member name. > > The variables for bridge loop avoidence, gateway handling, translation table > and visualization server are moved into separate structs that are included in > the bat_priv main struct. Great job! > Signed-off-by: Sven Eckelmann > --- > Any other ideas for substructs? I will definitely add a substruct for the catwoman feature as well. How aboug tt-entries in struct batadv_orig_node? -- Kind Regards Martin Hundebøll Frederiks Allé 99A, 1.th 8000 Aarhus C Denmark +45 61 65 54 61 martin@hundeboll.net