From: "Martin Hundebøll" <martin@hundeboll.net>
To: Antonio Quartulli <ordex@autistici.org>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Add the initial code for network coding.
Date: Tue, 27 Nov 2012 09:24:52 +0100 [thread overview]
Message-ID: <50B478D4.3080308@hundeboll.net> (raw)
In-Reply-To: <20121126002302.GH14547@ritirata.org>
On 2012-11-26 01:23, Antonio Quartulli wrote:
>> +/**
>> >+ * struct batadv_priv - per mesh interface private data
>> >+ * @network_coding: enable/disable network coding
>> >+ * @batadv_priv_nc: network coding private data
>> >+ */
>> > struct batadv_priv {
>> > atomic_t mesh_state;
>> > struct net_device_stats stats;
>> >@@ -308,6 +321,10 @@ struct batadv_priv {
>> > #ifdef CONFIG_BATMAN_ADV_DAT
>> > struct batadv_priv_dat dat;
>> > #endif
>> >+#ifdef CONFIG_BATMAN_ADV_NC
>> >+ atomic_t network_coding; /* boolean */
> just another style note: why don't you put this boolean switch together with the
> others?
Because of the sysfs-framework in batman-adv, that expects an atomic_t
with the same name as the file to be in batadv_priv - just like with
your DAT and Simon's BLAII :)
--
Kind Regards
Martin Hundebøll
Frederiks Allé 99, 1.th
8000 Aarhus C
Denmark
+45 61 65 54 61
martin@hundeboll.net
next prev parent reply other threads:[~2012-11-27 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 13:21 [B.A.T.M.A.N.] [RFC 0/6] CATWOMAN: Network coding in batman-adv Martin Hundebøll
2012-11-19 13:21 ` [B.A.T.M.A.N.] [RFC 1/6] batman-adv: Add the initial code for network coding Martin Hundebøll
2012-11-26 0:23 ` Antonio Quartulli
2012-11-27 8:24 ` Martin Hundebøll [this message]
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 2/6] batman-adv: Detect coding nodes and remove these after timeout Martin Hundebøll
2012-11-26 0:41 ` Antonio Quartulli
2012-11-26 1:15 ` Marek Lindner
2012-11-26 9:34 ` Antonio Quartulli
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 3/6] batman-adv: Buffer unicast packets before forward Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 4/6] batman-adv: Code and transmit packets if possible Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 5/6] batman-adv: Save overheard and tx packets for decoding Martin Hundebøll
2012-11-19 13:22 ` [B.A.T.M.A.N.] [RFC 6/6] batman-adv: Receive coded packets and decode them Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B478D4.3080308@hundeboll.net \
--to=martin@hundeboll.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox