Re: [B.A.T.M.A.N.] [PATCHv3 2/3] batman-adv: Receive fragmented packets and merge

["Martin Hundebøll" <martin@hundeboll.net>]

Hi Antonio,

Thanks for your carefull reviews!

On 2013-05-21 21:10, Antonio Quartulli wrote:
> On Tue, May 21, 2013 at 12:48:18PM +0200, Martin Hundebøll wrote:
>> +	/* Forward the fragment, if the merged packet would be too big to
>> +	 * be assembled.
>> +	 */
>> +	total_size = ntohs(packet->total_size) + ETH_HLEN;
>> +	if (total_size > neigh_node->if_incoming->net_dev->mtu) {
>
> I guess here you forgot to remove the ETH_LEN from the total_size computation.

True.

>> +		batadv_inc_counter(bat_priv, BATADV_CNT_FRAG_FWD);
>> +		batadv_add_counter(bat_priv, BATADV_CNT_FRAG_FWD_BYTES,
>> +				   skb->len + ETH_HLEN);
>
> and here should ETH_HLEN be counted in the amount of bytes sent?

I would say so, yes, since batadv_send_skb_packet() will add an ethernet 
header to the packet before transmitting it.

> Moreover we are always avoiding third person in kernel doc ("Returns" should be
> "Return" and so on..) and you should not put () (in the kernel doc).

Will do so and send another revision...

-- 
Kind Regards
Martin Hundebøll
Frederiks Allé 99, 1.th
8000 Aarhus C
Denmark

+45 61 65 54 61
martin@hundeboll.net